From: Andi Kleen <andi@firstfloor.org>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: akpm@linuxfoundation.org, linux-kernel@vger.kernel.org,
jbarnes@virtuousgeek.org
Subject: Re: [PATCH 5/5] Always print panic message on current console
Date: Mon, 12 Oct 2009 19:36:36 +0200 [thread overview]
Message-ID: <87d44sh5uj.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1255207870-24496-6-git-send-email-bernhard@bwalle.de> (Bernhard Walle's message of "Sat, 10 Oct 2009 22:51:10 +0200")
Bernhard Walle <bernhard@bwalle.de> writes:
> The kernel offers with TIOCL_GETKMSGREDIRECT ioctl() the possibility to
> redirect the kernel messages to a specific console.
>
> However, since it's not possible to switch to the kernel message console after
> a panic(), it would be nice if the kernel would print the panic message on the
> current console.
The basic idea is good, but you really need to call this in a lot
more places, which print some addition needed information before the panic.
The one liner panic is often not enough to decide what went wrong.
Example are machine checks, oopses, probably more.
In general for the recent work to switch the video mode on panic
we need a generalized hook for this anyways, so you could use
some generalized function.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-10-12 17:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 20:51 Always print panic message on current console Bernhard Walle
2009-10-10 20:51 ` [PATCH 1/5] Only define/declare kmsg_redirect when CONFIG_VT_CONSOLE is set Bernhard Walle
2009-10-10 22:56 ` Alan Cox
2009-10-10 20:51 ` [PATCH 2/5] Add setter/getter interface for kmsg_redirect Bernhard Walle
2009-10-10 22:58 ` Alan Cox
2009-10-10 20:51 ` [PATCH 3/5] Use vt_get_kmsg_redirect() and vt_set_kmsg_redirect() Bernhard Walle
2009-10-10 23:06 ` Alan Cox
2009-10-10 23:25 ` Alan Cox
2009-10-10 20:51 ` [PATCH 4/5] Make kmsg_redirect static Bernhard Walle
2009-10-10 20:51 ` [PATCH 5/5] Always print panic message on current console Bernhard Walle
2009-10-12 17:36 ` Andi Kleen [this message]
2009-10-12 18:24 ` Bernhard Walle
2009-10-12 18:30 ` Jesse Barnes
2009-10-12 18:34 ` Bernhard Walle
2009-10-14 0:02 ` Jason Wessel
2009-10-12 18:42 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d44sh5uj.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linuxfoundation.org \
--cc=bernhard@bwalle.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.