* [PATCH 2/4] Cleanup pre_restore_task comments
@ 2009-10-14 0:53 Matt Helsley
[not found] ` <1255481585-32625-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Matt Helsley @ 2009-10-14 0:53 UTC (permalink / raw)
To: Oren Laadan; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
We don't need to include the name of the function in the comment unless
it's a kerneldoc comment -- it's redundant. Also the comment before
post_restore_task() was copy-pasted without modification.
Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
checkpoint/process.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/checkpoint/process.c b/checkpoint/process.c
index c51e036..17c08e8 100644
--- a/checkpoint/process.c
+++ b/checkpoint/process.c
@@ -814,7 +814,7 @@ static int restore_task_pgid(struct ckpt_ctx *ctx)
return ret;
}
-/* pre_restore_task - prepare the task for restore */
+/* prepare the task for restore */
int pre_restore_task(struct ckpt_ctx *ctx)
{
sigset_t sigset;
@@ -844,7 +844,6 @@ int pre_restore_task(struct ckpt_ctx *ctx)
return 0;
}
-/* pre_restore_task - prepare the task for restore */
void post_restore_task(struct ckpt_ctx *ctx)
{
/* can happen if restart failed early */
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/4] Cleanup pre_restore_task comments
[not found] ` <1255481585-32625-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
@ 2009-10-14 22:34 ` Oren Laadan
0 siblings, 0 replies; 2+ messages in thread
From: Oren Laadan @ 2009-10-14 22:34 UTC (permalink / raw)
To: Matt Helsley; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Ok, pulled.
Matt Helsley wrote:
> We don't need to include the name of the function in the comment unless
> it's a kerneldoc comment -- it's redundant. Also the comment before
> post_restore_task() was copy-pasted without modification.
>
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> checkpoint/process.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/checkpoint/process.c b/checkpoint/process.c
> index c51e036..17c08e8 100644
> --- a/checkpoint/process.c
> +++ b/checkpoint/process.c
> @@ -814,7 +814,7 @@ static int restore_task_pgid(struct ckpt_ctx *ctx)
> return ret;
> }
>
> -/* pre_restore_task - prepare the task for restore */
> +/* prepare the task for restore */
> int pre_restore_task(struct ckpt_ctx *ctx)
> {
> sigset_t sigset;
> @@ -844,7 +844,6 @@ int pre_restore_task(struct ckpt_ctx *ctx)
> return 0;
> }
>
> -/* pre_restore_task - prepare the task for restore */
> void post_restore_task(struct ckpt_ctx *ctx)
> {
> /* can happen if restart failed early */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-14 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-14 0:53 [PATCH 2/4] Cleanup pre_restore_task comments Matt Helsley
[not found] ` <1255481585-32625-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-14 22:34 ` Oren Laadan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.