[Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[JosephChan]

Just remove redundant device ID for VT8261.

Signed-off-by: Joseph Chan <josephchan@via.com.tw>

--- a/drivers/ata/sata_via.c	2009-10-15 21:38:14.000000000 +0800
+++ b/drivers/ata/sata_via.c	2009-10-15 21:38:28.000000000 +0800
@@ -93,7 +93,6 @@
 	{ PCI_VDEVICE(VIA, 0x7372), vt6420 },
 	{ PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */
 	{ PCI_VDEVICE(VIA, 0x9000), vt8251 },
-	{ PCI_VDEVICE(VIA, 0x9040), vt8251 },
 
 	{ }	/* terminate list */
 };

Re: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[Jeff Garzik]

On 10/15/2009 03:10 AM, JosephChan@via.com.tw wrote:
> Just remove redundant device ID for VT8261.
>
> Signed-off-by: Joseph Chan<josephchan@via.com.tw>
>
> --- a/drivers/ata/sata_via.c	2009-10-15 21:38:14.000000000 +0800
> +++ b/drivers/ata/sata_via.c	2009-10-15 21:38:28.000000000 +0800
> @@ -93,7 +93,6 @@
>   	{ PCI_VDEVICE(VIA, 0x7372), vt6420 },
>   	{ PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */
>   	{ PCI_VDEVICE(VIA, 0x9000), vt8251 },
> -	{ PCI_VDEVICE(VIA, 0x9040), vt8251 },

PCI device ID 0x9040 does not exist elsewhere in the driver...  how is 
it redundant?

	Jeff

Re: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[Tejun Heo]

JosephChan@via.com.tw wrote:
> Just remove redundant device ID for VT8261.
> 
> Signed-off-by: Joseph Chan <josephchan@via.com.tw>

Looks okay to me.

> --- a/drivers/ata/sata_via.c	2009-10-15 21:38:14.000000000 +0800
> +++ b/drivers/ata/sata_via.c	2009-10-15 21:38:28.000000000 +0800
> @@ -93,7 +93,6 @@
>  	{ PCI_VDEVICE(VIA, 0x7372), vt6420 },
>  	{ PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */
>  	{ PCI_VDEVICE(VIA, 0x9000), vt8251 },
> -	{ PCI_VDEVICE(VIA, 0x9040), vt8251 },
>  
>  	{ }	/* terminate list */
>  };
> 
> N�����r��y���b�X��ǧv�^�)޺{.n�+����{��ע��^n�r��z�\x1a��h����&��\x1e�G���h�\x03(�階�ݢj"��\x1a�^[m�����z�ޖ���f���h���~�mml==

But, what's the above garbled line?

-- 
tejun

RE: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[JosephChan]

> PCI device ID 0x9040 does not exist elsewhere in the driver...  how is it redundant?

1. So far, there is no VT8261 silicon in the public market.
2. Device ID 0x9000 and 0x9040 are redundant (for VT8261). The 0x9040 is reserved for other usage.

BRs,
Joseph

Re: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[Jeff Garzik]

On 10/15/2009 03:19 AM, Tejun Heo wrote:
> JosephChan@via.com.tw wrote:
>> Just remove redundant device ID for VT8261.
>>
>> Signed-off-by: Joseph Chan<josephchan@via.com.tw>
>
> Looks okay to me.
>
>> --- a/drivers/ata/sata_via.c	2009-10-15 21:38:14.000000000 +0800
>> +++ b/drivers/ata/sata_via.c	2009-10-15 21:38:28.000000000 +0800
>> @@ -93,7 +93,6 @@
>>   	{ PCI_VDEVICE(VIA, 0x7372), vt6420 },
>>   	{ PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */
>>   	{ PCI_VDEVICE(VIA, 0x9000), vt8251 },
>> -	{ PCI_VDEVICE(VIA, 0x9040), vt8251 },
>>
>>   	{ }	/* terminate list */
>>   };
>>
>> N�����r��y���b�X��ǧv�^�)޺{.n�+����{��ע��^n�r��z�\x1a��h����&��\x1e�G���h�\x03(�階�ݢj"��\x1a�^[m�����z�ޖ���f���h���~�mml==
>
> But, what's the above garbled line?

(cc'ing postmaster@vger)

It is interesting that Joseph's email directly to me was OK, but the 
copy passing through vger.kernel.org list software included this garbled 
line.

Joseph's email was base64-encoded, and vger just got new mailing list 
software in the past year or so...   so I wonder if this is a vger bug?

	Jeff

RE: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[JosephChan]

>>  But, what's the above garbled line?

> Joseph's email was base64-encoded, and vger just got new mailing list 
> software in the past year or so...   so I wonder if this is a vger bug?

Sorry, it should be my editor's bug.
I copied the patch with an extra blank line. And it caused the grabled line you saw. 
I will resend this patch later if there is no problem for this patch. :)

BRs,
Joseph Chan 

Re: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[David Miller]

From: Jeff Garzik <jeff@garzik.org>
Date: Thu, 15 Oct 2009 03:36:10 -0400

> Joseph's email was base64-encoded, and vger just got new mailing list
> software in the past year or so...  so I wonder if this is a vger bug?

vger hasn't had new mailing list software in 10 years :-)

Re: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[Jeff Garzik]

On 10/15/2009 11:37 AM, David Miller wrote:
> From: Jeff Garzik<jeff@garzik.org>
> Date: Thu, 15 Oct 2009 03:36:10 -0400
>
>> Joseph's email was base64-encoded, and vger just got new mailing list
>> software in the past year or so...  so I wonder if this is a vger bug?
>
> vger hasn't had new mailing list software in 10 years :-)

I thought Matti was working on something new, but I guess I was mistaken.

	Jeff

Re: [Patch 1/1] sata_via.c: Remove redundant device ID for VT8261

[David Miller]

From: Jeff Garzik <jeff@garzik.org>
Date: Thu, 15 Oct 2009 11:46:54 -0400

> On 10/15/2009 11:37 AM, David Miller wrote:
>> From: Jeff Garzik<jeff@garzik.org>
>> Date: Thu, 15 Oct 2009 03:36:10 -0400
>>
>>> Joseph's email was base64-encoded, and vger just got new mailing list
>>> software in the past year or so...  so I wonder if this is a vger bug?
>>
>> vger hasn't had new mailing list software in 10 years :-)
> 
> I thought Matti was working on something new, but I guess I was
> mistaken.

Yes, but as far as I am aware it isn't live yet.