[lm-sensors] [PATCH] hwmon: Fix check on unsigned in

[lm-sensors] [PATCH] hwmon: Fix check on unsigned in

[Roel Kluin]

If unsigned the watchdog_trigger() return value will not be
checked correctly.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c
index 2a7a85a..da1b1f9 100644
--- a/drivers/hwmon/fschmd.c
+++ b/drivers/hwmon/fschmd.c
@@ -819,7 +819,7 @@ static int watchdog_release(struct inode *inode, struct file *filp)
 static ssize_t watchdog_write(struct file *filp, const char __user *buf,
 	size_t count, loff_t *offset)
 {
-	size_t ret;
+	int ret;
 	struct fschmd_data *data = filp->private_data;
 
 	if (count) {

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: Fix check on unsigned in

[Jean Delvare]

On Fri, 16 Oct 2009 16:48:38 +0200, Roel Kluin wrote:
> If unsigned the watchdog_trigger() return value will not be
> checked correctly.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c
> index 2a7a85a..da1b1f9 100644
> --- a/drivers/hwmon/fschmd.c
> +++ b/drivers/hwmon/fschmd.c
> @@ -819,7 +819,7 @@ static int watchdog_release(struct inode *inode, struct file *filp)
>  static ssize_t watchdog_write(struct file *filp, const char __user *buf,
>  	size_t count, loff_t *offset)
>  {
> -	size_t ret;
> +	int ret;
>  	struct fschmd_data *data = filp->private_data;
>  
>  	if (count) {

Good catch. Patch applied, thanks.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors