Re: [PATCH] Let user specify OpenBSD root device.

[Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>]

Robert Millan wrote:
> On Fri, Oct 16, 2009 at 01:00:31PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>   
>> Vladimir 'phcoder' Serbinenko wrote:
>>     
>>> On Wed, Aug 26, 2009 at 2:34 AM, Robert Millan<rmh@aybabtu.com> wrote:
>>>   
>>>       
>>>> On Tue, Aug 25, 2009 at 10:37:33PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>>>>     
>>>>         
>>>>> +  if (cmd->state[OPENBSD_ROOT_ARG].set)
>>>>> +    {
>>>>> +      const char *arg = cmd->state[OPENBSD_ROOT_ARG].arg;
>>>>> +      int unit, part;
>>>>> +      if (*(arg++) != 'w' || *(arg++) != 'd')
>>>>> +     return grub_error (GRUB_ERR_BAD_ARGUMENT,
>>>>> +                        "Only device specifications of form "
>>>>> +                        "wd<number><lowercase letter> are supported.");
>>>>> +
>>>>> +      unit = grub_strtoul (arg, (char **) &arg, 10);
>>>>> +      if (! (arg && *arg >= 'a' && *arg <= 'z'))
>>>>> +     return grub_error (GRUB_ERR_BAD_ARGUMENT,
>>>>> +                        "Only device specifications of form "
>>>>> +                        "wd<number><letter> are supported.");
>>>>>       
>>>>>           
>>>> Looks like the first error string could be used for both cases, saving
>>>> a few bytes.
>>>>
>>>>     
>>>>         
>> This was fixed. Can this patch be comitted before release to avoid
>> changing command syntax after release?
>>     
>
> Ok.
>
>   
Comitted

-- 
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git