All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: john stultz <johnstul@us.ibm.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Xen-devel <xen-devel@lists.xensource.com>,
	kurt.hackel@oracle.com, arch/x86 maintainers <x86@kernel.org>,
	Glauber de Oliveira Costa <gcosta@redhat.com>,
	Avi Kivity <avi@redhat.com>,
	chris.mason@oracle.com
Subject: Re: [Xen-devel] [PATCH 05/12] xen/pvclock: add monotonicity check
Date: Sun, 18 Oct 2009 17:18:08 +0900	[thread overview]
Message-ID: <4ADACF40.20700@goop.org> (raw)
In-Reply-To: <1255715898.5135.9.camel@localhost.localdomain>

On 10/17/09 02:58, john stultz wrote:
>> (I can think of plenty of ways of doing it incorrectly, where you'd get
>> apparent non-monotonicity regardless of the quality of the time source.)
>>     
> There's been some interesting talk of creating a more offset-robust TSC
> clocksource using a per-cpu TSC offsets synced periodically against a
> global counter like the HPET.  It seems like it could work, but there
> are a lot of edge cases and it really has to be right all of the time,
> so I don't think its quite as trivial as some folks have thought. But it
> would be interesting to see!
>   

Xen and KVM do this already.  The host system provides the tsc rate and
offset information for each cpu so that the guest kernel can compute a
global system time (ns since boot) from the tsc.

I suspect its quite difficult to guarantee that you get completely
monotonic results if the tscs are at different rates, but if they're the
same rate but merely offset it should give completely OK results.

    J

WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: john stultz <johnstul@us.ibm.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Xen-devel <xen-devel@lists.xensource.com>,
	kurt.hackel@oracle.com, arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Glauber de Oliveira Costa <gcosta@redhat.com>,
	Avi Kivity <avi@redhat.com>,
	chris.mason@oracle.com
Subject: Re: [PATCH 05/12] xen/pvclock: add monotonicity check
Date: Sun, 18 Oct 2009 17:18:08 +0900	[thread overview]
Message-ID: <4ADACF40.20700@goop.org> (raw)
In-Reply-To: <1255715898.5135.9.camel@localhost.localdomain>

On 10/17/09 02:58, john stultz wrote:
>> (I can think of plenty of ways of doing it incorrectly, where you'd get
>> apparent non-monotonicity regardless of the quality of the time source.)
>>     
> There's been some interesting talk of creating a more offset-robust TSC
> clocksource using a per-cpu TSC offsets synced periodically against a
> global counter like the HPET.  It seems like it could work, but there
> are a lot of edge cases and it really has to be right all of the time,
> so I don't think its quite as trivial as some folks have thought. But it
> would be interesting to see!
>   

Xen and KVM do this already.  The host system provides the tsc rate and
offset information for each cpu so that the guest kernel can compute a
global system time (ns since boot) from the tsc.

I suspect its quite difficult to guarantee that you get completely
monotonic results if the tscs are at different rates, but if they're the
same rate but merely offset it should give completely OK results.

    J

  reply	other threads:[~2009-10-18  8:18 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14 19:28 [GIT PULL RFC] pvclock cleanups and pvclock vsyscall support Jeremy Fitzhardinge
2009-10-14 19:28 ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 01/12] x86/vsyscall: use common implementation for vgetcpu Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 02/12] x86/vgetcpu: ignore tcache in common code Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 03/12] x86/vsyscall: use common implementation for vgettimeofday Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 04/12] kvm/pvclock: add monotonicity check Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 05/12] xen/pvclock: " Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-15  3:26   ` [Xen-devel] " Dan Magenheimer
2009-10-15  3:26     ` Dan Magenheimer
2009-10-15  5:24     ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-15  5:24       ` Jeremy Fitzhardinge
2009-10-15 13:27       ` [Xen-devel] " Dan Magenheimer
2009-10-15 13:27         ` Dan Magenheimer
2009-10-15 19:19         ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-15 19:19           ` Jeremy Fitzhardinge
2009-10-16  1:32         ` [Xen-devel] " john stultz
2009-10-16  3:10           ` Jeremy Fitzhardinge
2009-10-16  3:10             ` Jeremy Fitzhardinge
2009-10-16 17:58             ` [Xen-devel] " john stultz
2009-10-16 17:58               ` john stultz
2009-10-18  8:18               ` Jeremy Fitzhardinge [this message]
2009-10-18  8:18                 ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 06/12] x86/pvclock: make sure rdtsc doesn't speculate out of region Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 07/12] pvclock: there's no need to copy time_info into shadow Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 08/12] x86: create specific X86_VSYSCALL config variable Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 09/12] sched: add notifier for cross-cpu migrations Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 10/12] x86/pvclock: add vsyscall implementation Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 11/12] x86/fixmap: add a predicate for usermode fixmaps Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-14 19:28 ` [PATCH 12/12] xen/time: add pvclock_clocksource_vread support Jeremy Fitzhardinge
2009-10-14 19:28   ` Jeremy Fitzhardinge
2009-10-15  6:51 ` [GIT PULL RFC] pvclock cleanups and pvclock vsyscall support Avi Kivity
2009-10-15  6:51   ` Avi Kivity
2009-10-15 19:46   ` Jeremy Fitzhardinge
2009-10-15 19:46     ` Jeremy Fitzhardinge
2009-10-18  6:43     ` Avi Kivity
2009-10-18  6:43       ` Avi Kivity
2009-10-18  8:18       ` Jeremy Fitzhardinge
2009-10-18  8:18         ` Jeremy Fitzhardinge
2009-10-18  8:23         ` Avi Kivity
2009-10-18  8:23           ` Avi Kivity
2009-10-18  8:44           ` Jeremy Fitzhardinge
2009-10-18  8:44             ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADACF40.20700@goop.org \
    --to=jeremy@goop.org \
    --cc=avi@redhat.com \
    --cc=chris.mason@oracle.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=gcosta@redhat.com \
    --cc=johnstul@us.ibm.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.