From: Eric Dumazet <eric.dumazet@gmail.com>
To: Michal Ostrowski <mostrows@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
Denys Fedoryschenko <denys@visp.net.lb>,
netdev <netdev@vger.kernel.org>,
linux-ppp@vger.kernel.org, paulus@samba.org,
mostrows@earthlink.net
Subject: Re: kernel panic in latest vanilla stable, while using nameif with
Date: Tue, 20 Oct 2009 03:42:26 +0000 [thread overview]
Message-ID: <4ADD31A2.4030702@gmail.com> (raw)
In-Reply-To: <e6d1cecd0910191354o16d023d2lbe2761a97e88acea@mail.gmail.com>
Michal Ostrowski a écrit :
> Access of po->pppoe_dev is guarded by sk->sk_state & PPPOX_CONNECTED,
> and all use cases now rely on the socket lock. Because of this, the
> ref-count on the namespace held by the socket object suffices to hold
> the namespace in existence and so we don't need to ref-count the
> namespace in PPPoE. The flush_lock is gone.
>
Seems good !
But can we use lock_sock() in __pppoe_xmit() context ?
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Michal Ostrowski <mostrows@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
Denys Fedoryschenko <denys@visp.net.lb>,
netdev <netdev@vger.kernel.org>,
linux-ppp@vger.kernel.org, paulus@samba.org,
mostrows@earthlink.net
Subject: Re: kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces
Date: Tue, 20 Oct 2009 05:42:26 +0200 [thread overview]
Message-ID: <4ADD31A2.4030702@gmail.com> (raw)
In-Reply-To: <e6d1cecd0910191354o16d023d2lbe2761a97e88acea@mail.gmail.com>
Michal Ostrowski a écrit :
> Access of po->pppoe_dev is guarded by sk->sk_state & PPPOX_CONNECTED,
> and all use cases now rely on the socket lock. Because of this, the
> ref-count on the namespace held by the socket object suffices to hold
> the namespace in existence and so we don't need to ref-count the
> namespace in PPPoE. The flush_lock is gone.
>
Seems good !
But can we use lock_sock() in __pppoe_xmit() context ?
next prev parent reply other threads:[~2009-10-20 3:42 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 21:02 kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Denys Fedoryschenko
2009-10-18 21:02 ` Denys Fedoryschenko
2009-10-19 3:34 ` kernel panic in latest vanilla stable, while using nameif with Michal Ostrowski
2009-10-19 3:34 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Michal Ostrowski
2009-10-19 11:36 ` Denys Fedoryschenko
2009-10-19 11:36 ` Denys Fedoryschenko
2009-10-19 12:01 ` Denys Fedoryschenko
2009-10-19 12:01 ` Denys Fedoryschenko
2009-10-19 12:36 ` kernel panic in latest vanilla stable, while using nameif with Eric Dumazet
2009-10-19 12:36 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Eric Dumazet
2009-10-19 13:19 ` kernel panic in latest vanilla stable, while using nameif with Michal Ostrowski
2009-10-19 13:19 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Michal Ostrowski
2009-10-19 15:50 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-19 15:50 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-19 16:05 ` kernel panic in latest vanilla stable, while using nameif with Michal Ostrowski
2009-10-19 16:05 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Michal Ostrowski
2009-10-19 17:12 ` kernel panic in latest vanilla stable, while using nameif with Eric Dumazet
2009-10-19 17:12 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Eric Dumazet
2009-10-19 18:07 ` kernel panic in latest vanilla stable, while using nameif with Michal Ostrowski
2009-10-19 18:07 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Michal Ostrowski
2009-10-19 18:44 ` kernel panic in latest vanilla stable, while using nameif with Eric Dumazet
2009-10-19 18:44 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Eric Dumazet
2009-10-19 19:29 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-19 19:29 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-19 20:54 ` kernel panic in latest vanilla stable, while using nameif with Michal Ostrowski
2009-10-19 20:54 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Michal Ostrowski
2009-10-20 3:42 ` Eric Dumazet [this message]
2009-10-20 3:42 ` Eric Dumazet
2009-10-20 5:02 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 5:02 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-20 5:05 ` kernel panic in latest vanilla stable, while using nameif with Eric Dumazet
2009-10-20 5:05 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Eric Dumazet
2009-10-20 5:17 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 5:17 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-20 6:04 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 6:04 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-19 20:57 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-19 20:57 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-19 21:22 ` kernel panic in latest vanilla stable, while using nameif with Michal Ostrowski
2009-10-19 21:22 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Michal Ostrowski
2009-10-20 0:08 ` Denys Fedoryschenko
2009-10-20 0:08 ` Denys Fedoryschenko
2009-10-20 3:04 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 3:04 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-20 11:36 ` Denys Fedoryschenko
2009-10-20 11:36 ` Denys Fedoryschenko
2009-10-20 11:50 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 11:50 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-20 11:52 ` Denys Fedoryschenko
2009-10-20 11:52 ` Denys Fedoryschenko
2009-10-20 13:42 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 13:42 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-20 13:50 ` Denys Fedoryschenko
2009-10-20 13:50 ` Denys Fedoryschenko
2009-10-20 13:59 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 13:59 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-20 14:20 ` Denys Fedoryschenko
2009-10-20 14:20 ` Denys Fedoryschenko
2009-10-20 14:23 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 14:23 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-20 19:08 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-20 19:08 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-23 15:18 ` kernel panic in latest vanilla stable, while using nameif with Cyrill Gorcunov
2009-10-23 15:18 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces Cyrill Gorcunov
2009-10-25 18:10 ` Denys Fedoryschenko
2009-10-25 18:10 ` Denys Fedoryschenko
2009-10-20 2:28 ` kernel panic in latest vanilla stable, while using nameif with David Miller
2009-10-20 2:28 ` kernel panic in latest vanilla stable, while using nameif with "alive" pppoe interfaces David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADD31A2.4030702@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=denys@visp.net.lb \
--cc=gorcunov@gmail.com \
--cc=linux-ppp@vger.kernel.org \
--cc=mostrows@earthlink.net \
--cc=mostrows@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.