From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation
Date: Wed, 21 Oct 2009 13:30:51 -0500 [thread overview]
Message-ID: <4ADF535B.9090308@codemonkey.ws> (raw)
In-Reply-To: <0103B4C8-A94C-4556-95A0-FAFEBA436624@suse.de>
Alexander Graf wrote:
>
> On 21.10.2009, at 20:06, Anthony Liguori wrote:
>
>> Alexander Graf wrote:
>>> So you would prefer a special #ifdef for s390 in generic code over a
>>> specifically for this purpose exported function?
>>>
>>> Well, you're the boss. I like the special function better, but
>>> whatever you say.
>>
>> How is someone supposed to figure out what _qemu_ram_alloc is for?
>> Nothing in your patch really indicates that.
>>
>> However, an ugly #ifdef immediately tells someone, oh, s390 kvm needs
>> this terrible hack, so let's keep bugging those guys to eliminate the
>> need for that.
>
> Alright :-). Any other complaints? If not I'd spin up v3.
Nope.
Regards,
Anthony Liguori
> Alex
>
next prev parent reply other threads:[~2009-10-21 18:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 9:24 [Qemu-devel] [PATCH 0/9] S390x KVM support v2 Alexander Graf
2009-10-21 9:24 ` [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation Alexander Graf
2009-10-21 9:24 ` [Qemu-devel] [PATCH 2/9] Add KVM support for S390x Alexander Graf
2009-10-21 9:25 ` [Qemu-devel] [PATCH 3/9] Add support for S390x system emulation Alexander Graf
2009-10-21 9:25 ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Alexander Graf
2009-10-21 9:25 ` [Qemu-devel] [PATCH 5/9] Add S390x virtio machine description Alexander Graf
2009-10-21 9:25 ` [Qemu-devel] [PATCH 6/9] S390 GDB stub Alexander Graf
2009-10-21 9:25 ` [Qemu-devel] [PATCH 7/9] Implement early printk in virtio-console Alexander Graf
2009-10-21 9:25 ` [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x Alexander Graf
2009-10-21 9:25 ` [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON Alexander Graf
2009-10-21 14:29 ` [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation Anthony Liguori
2009-10-21 16:02 ` Alexander Graf
2009-10-21 16:54 ` Anthony Liguori
2009-10-21 17:03 ` Alexander Graf
2009-10-21 18:06 ` Anthony Liguori
2009-10-21 18:27 ` Alexander Graf
2009-10-21 18:30 ` Anthony Liguori [this message]
2009-10-21 18:42 ` [Qemu-devel] " Paolo Bonzini
2009-10-21 18:48 ` Anthony Liguori
2009-10-22 5:39 ` [Qemu-devel] " Carsten Otte
2009-10-21 11:03 ` [Qemu-devel] Re: [PATCH 0/9] S390x KVM support v2 Carsten Otte
-- strict thread matches above, loose matches on Subject: below --
2009-10-19 14:37 [Qemu-devel] [PATCH 0/9] S390x KVM support Alexander Graf
2009-10-19 14:37 ` [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADF535B.9090308@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=cotte@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.