From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Subject: Re: [PATCH] Enable 32bit dirty log pointers on 64bit host
Date: Thu, 22 Oct 2009 10:32:17 +0000 [thread overview]
Message-ID: <4AE034B1.4000101@redhat.com> (raw)
In-Reply-To: <03CB8BC3-B33F-4253-A259-A1517A099698-l3A5Bk7waGM@public.gmane.org>
On 10/22/2009 12:25 PM, Alexander Graf wrote:
>> If you send someone's patch, you need to sign this off. That says
>> you are legally allowed to send it along.
>>
>> Ack means "I have a say in this area and it looks good to me", you
>> add it when someone else is doing the sending.
>
>
> Ok, so is it still a From: Arnd then? Is it still signed-off by Arnd
> even though I change it?
Yes. Most kvm patches are From: other people, I just add my signoff
(and definitely don't remote theirs).
Whether to change From: depends on the changes. If you rewrite the
patch, it's From: you. If you just fix a couple of bugs, you generally
leave From: alone.
> Is there a Based-on-patch-by: tag? :-)
You can always say "Based on initial patch from ...".
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Subject: Re: [PATCH] Enable 32bit dirty log pointers on 64bit host
Date: Thu, 22 Oct 2009 12:32:17 +0200 [thread overview]
Message-ID: <4AE034B1.4000101@redhat.com> (raw)
In-Reply-To: <03CB8BC3-B33F-4253-A259-A1517A099698-l3A5Bk7waGM@public.gmane.org>
On 10/22/2009 12:25 PM, Alexander Graf wrote:
>> If you send someone's patch, you need to sign this off. That says
>> you are legally allowed to send it along.
>>
>> Ack means "I have a say in this area and it looks good to me", you
>> add it when someone else is doing the sending.
>
>
> Ok, so is it still a From: Arnd then? Is it still signed-off by Arnd
> even though I change it?
Yes. Most kvm patches are From: other people, I just add my signoff
(and definitely don't remote theirs).
Whether to change From: depends on the changes. If you rewrite the
patch, it's From: you. If you just fix a couple of bugs, you generally
leave From: alone.
> Is there a Based-on-patch-by: tag? :-)
You can always say "Based on initial patch from ...".
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-10-22 10:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 14:08 [PATCH] Enable 32bit dirty log pointers on 64bit host Alexander Graf
2009-10-21 14:08 ` Alexander Graf
2009-10-22 10:23 ` Avi Kivity
2009-10-22 10:23 ` Avi Kivity
2009-10-22 10:25 ` Alexander Graf
2009-10-22 10:25 ` Alexander Graf
[not found] ` <03CB8BC3-B33F-4253-A259-A1517A099698-l3A5Bk7waGM@public.gmane.org>
2009-10-22 10:32 ` Avi Kivity [this message]
2009-10-22 10:32 ` Avi Kivity
2009-10-22 12:19 ` Alexander Graf
2009-10-22 12:19 ` Alexander Graf
2009-10-22 20:39 ` Marcelo Tosatti
2009-10-22 20:39 ` Marcelo Tosatti
2009-10-23 8:41 ` Jan Kiszka
2009-10-23 8:41 ` Jan Kiszka
[not found] ` <4AE16C50.1060806-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2009-10-23 9:12 ` Alexander Graf
2009-10-23 9:12 ` Alexander Graf
2009-10-23 9:15 ` Jan Kiszka
2009-10-23 9:15 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE034B1.4000101@redhat.com \
--to=avi@redhat.com \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.