* [PATCH] kvmppc: Fix BUILD_BUG_ON condition
@ 2009-10-23 0:35 Hollis Blanchard
2009-10-25 13:02 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Hollis Blanchard @ 2009-10-23 0:35 UTC (permalink / raw)
To: kvm-ppc
The old BUILD_BUG_ON implementation didn't work with __builtin_constant_p().
Fixing that revealed this test had been inverted for a long time without
anybody noticing...
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
diff --git a/arch/powerpc/kvm/timing.h b/arch/powerpc/kvm/timing.h
--- a/arch/powerpc/kvm/timing.h
+++ b/arch/powerpc/kvm/timing.h
@@ -48,7 +48,7 @@ static inline void kvmppc_set_exit_type(
static inline void kvmppc_account_exit_stat(struct kvm_vcpu *vcpu, int type)
{
/* type has to be known at build time for optimization */
- BUILD_BUG_ON(__builtin_constant_p(type));
+ BUILD_BUG_ON(!__builtin_constant_p(type));
switch (type) {
case EXT_INTR_EXITS:
vcpu->stat.ext_intr_exits++;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kvmppc: Fix BUILD_BUG_ON condition
2009-10-23 0:35 [PATCH] kvmppc: Fix BUILD_BUG_ON condition Hollis Blanchard
@ 2009-10-25 13:02 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2009-10-25 13:02 UTC (permalink / raw)
To: kvm-ppc
On 10/23/2009 02:35 AM, Hollis Blanchard wrote:
> The old BUILD_BUG_ON implementation didn't work with __builtin_constant_p().
> Fixing that revealed this test had been inverted for a long time without
> anybody noticing...
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-25 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-23 0:35 [PATCH] kvmppc: Fix BUILD_BUG_ON condition Hollis Blanchard
2009-10-25 13:02 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.