From: Tilman Schmidt <tilman@imap.cc>
To: unlisted-recipients:; (no To-header on input)
Cc: David Miller <davem@davemloft.net>,
Karsten Keil <isdn@linux-pingi.de>,
Hansjoerg Lipp <hjlipp@web.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
isdn4linux@listserv.isdn4linux.de,
i4ldeveloper@listserv.isdn4linux.de
Subject: Re: [PATCH 6/9] ser_gigaset: checkpatch cleanup
Date: Mon, 26 Oct 2009 00:36:58 +0100 [thread overview]
Message-ID: <4AE4E11A.7000303@imap.cc> (raw)
In-Reply-To: <20091025203705.273e1c14@lxorguk.ukuu.org.uk>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
Alan Cox schrieb:
>> - if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue)))
>> + nextskb = skb_dequeue(&bcs->squeue);
>> + if (!nextskb)
>> /* no skb either, nothing to do */
>> return;
>> + bcs->tx_skb = nextskb;
>
> This does not do the same thing as before
>
> Previously the NULL case assigned to bcs->tx_skb, now it does not.
bcs->tx_skb is guaranteed to be NULL already at this point because
of the enclosing "if (!bcs->tx_skb)".
Thanks,
Tilman
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
next prev parent reply other threads:[~2009-10-25 23:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-25 19:29 [PATCH 0/9] Gigaset driver patches for 2.6.33 Tilman Schmidt
2009-10-25 19:29 ` [PATCH 1/9] gigaset: CAPI module readability improvements Tilman Schmidt
2009-10-25 19:29 ` [PATCH 2/9] gigaset: fix format string typo in CAPI dial command Tilman Schmidt
2009-10-25 19:29 ` [PATCH 3/9] gigaset: fix bad assumptions about CAPI skbuffs Tilman Schmidt
2009-10-25 19:30 ` [PATCH 4/9] usb_gigaset: code cleanup Tilman Schmidt
2009-10-25 19:30 ` [PATCH 5/9] gigaset: checkpatch cleanup Tilman Schmidt
2009-10-25 19:30 ` [PATCH 6/9] ser_gigaset: " Tilman Schmidt
2009-10-25 20:37 ` Alan Cox
2009-10-25 23:36 ` Tilman Schmidt [this message]
2009-10-26 0:54 ` Joe Perches
2009-10-26 23:59 ` Tilman Schmidt
2009-10-27 0:14 ` Joe Perches
2009-10-27 10:20 ` Karsten Keil
2009-10-25 19:30 ` [PATCH 7/9] bas_gigaset: " Tilman Schmidt
2009-10-25 19:30 ` [PATCH 8/9] gigaset: checkpatch cleanup of ev-layer.c Tilman Schmidt
2009-10-25 19:30 ` [PATCH 9/9] gigaset: convert strcmp chain to table lookup Tilman Schmidt
2009-10-29 8:37 ` [PATCH 0/9] Gigaset driver patches for 2.6.33 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE4E11A.7000303@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.