From: Sunil Mushran <sunil.mushran@oracle.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] fiemap: Add new extent flag FIEMAP_EXTENT_SHARED
Date: Mon, 26 Oct 2009 10:29:36 -0700 [thread overview]
Message-ID: <4AE5DC80.8010204@oracle.com> (raw)
In-Reply-To: <20091024183039.GB30762@shareable.org>
Jamie Lokier wrote:
> It might be better to have a flag FIEMAP_EXTENT_NOT_SHARED.
>
> Apps which need to know the data is not shared can't safely check
> !(flags & FIEMAP_EXTENT_SHARED) because of old kernels which don't set
> the flag.
I'm probably not understanding your point. Won't the older kernels not set
FIEMAP_EXTENT_NOT_SHARED too.
If this is important, we could always add this flag in the stable kernel
trees. Both sharing of extents and fiemap are relatively new to the kernel.
WARNING: multiple messages have this Message-ID (diff)
From: Sunil Mushran <sunil.mushran@oracle.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 1/2] fiemap: Add new extent flag FIEMAP_EXTENT_SHARED
Date: Mon, 26 Oct 2009 10:29:36 -0700 [thread overview]
Message-ID: <4AE5DC80.8010204@oracle.com> (raw)
In-Reply-To: <20091024183039.GB30762@shareable.org>
Jamie Lokier wrote:
> It might be better to have a flag FIEMAP_EXTENT_NOT_SHARED.
>
> Apps which need to know the data is not shared can't safely check
> !(flags & FIEMAP_EXTENT_SHARED) because of old kernels which don't set
> the flag.
I'm probably not understanding your point. Won't the older kernels not set
FIEMAP_EXTENT_NOT_SHARED too.
If this is important, we could always add this flag in the stable kernel
trees. Both sharing of extents and fiemap are relatively new to the kernel.
WARNING: multiple messages have this Message-ID (diff)
From: Sunil Mushran <sunil.mushran@oracle.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 1/2] fiemap: Add new extent flag FIEMAP_EXTENT_SHARED
Date: Mon, 26 Oct 2009 10:29:36 -0700 [thread overview]
Message-ID: <4AE5DC80.8010204@oracle.com> (raw)
In-Reply-To: <20091024183039.GB30762@shareable.org>
Jamie Lokier wrote:
> It might be better to have a flag FIEMAP_EXTENT_NOT_SHARED.
>
> Apps which need to know the data is not shared can't safely check
> !(flags & FIEMAP_EXTENT_SHARED) because of old kernels which don't set
> the flag.
I'm probably not understanding your point. Won't the older kernels not set
FIEMAP_EXTENT_NOT_SHARED too.
If this is important, we could always add this flag in the stable kernel
trees. Both sharing of extents and fiemap are relatively new to the kernel.
next prev parent reply other threads:[~2009-10-26 17:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 1:05 [Ocfs2-devel] Extend FIEMAP to indicate shared extents Sunil Mushran
2009-10-22 1:05 ` Sunil Mushran
2009-10-22 1:05 ` [Ocfs2-devel] [PATCH 1/2] fiemap: Add new extent flag FIEMAP_EXTENT_SHARED Sunil Mushran
2009-10-22 1:05 ` Sunil Mushran
2009-10-23 18:00 ` [Ocfs2-devel] " Mark Fasheh
2009-10-23 18:00 ` Mark Fasheh
2009-10-24 18:30 ` Jamie Lokier
2009-10-24 18:30 ` Jamie Lokier
2009-10-26 17:29 ` Sunil Mushran [this message]
2009-10-26 17:29 ` Sunil Mushran
2009-10-26 17:29 ` [Ocfs2-devel] " Sunil Mushran
2009-10-26 19:29 ` Brad Boyer
2009-10-26 19:29 ` Brad Boyer
2009-10-22 1:05 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: Use FIEMAP_EXTENT_SHARED Sunil Mushran
2009-10-22 1:05 ` Sunil Mushran
-- strict thread matches above, loose matches on Subject: below --
2009-11-06 23:24 [Ocfs2-devel] Extend FIEMAP to indicate shared extents Sunil Mushran
2009-11-06 23:24 ` [Ocfs2-devel] [PATCH 1/2] fiemap: Add new extent flag FIEMAP_EXTENT_SHARED Sunil Mushran
2009-12-03 20:46 [Ocfs2-devel] Add FIEMAP_EXTENT_SHARED flag Sunil Mushran
2009-12-03 20:46 ` [Ocfs2-devel] [PATCH 1/2] fiemap: Add new extent flag FIEMAP_EXTENT_SHARED Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE5DC80.8010204@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=jamie@shareable.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.