All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 2/4] megasas: LSI MegaRAID SAS HBA emulation
Date: Tue, 27 Oct 2009 17:59:28 +0100	[thread overview]
Message-ID: <4AE726F0.9010800@redhat.com> (raw)
In-Reply-To: <20091027152849.F37C439742@ochil.suse.de>

   Hi,

> +    /* The current Qemu infrastructure allows only for LUN 0 */
> +    if (lun == 0&&  target<  MAX_RAID_DEVS)
> +	cmd->lun =&s->luns[target];

One more thing which should be fixed in qemu instead of worked around in 
your driver.  After all even good old parallel scsi knows multiple luns. 
  Guess this is how you end up with 128 scsi devices (16 ids with 8 luns 
each)?

cheers,
   Gerd

WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 2/4] megasas: LSI MegaRAID SAS HBA emulation
Date: Tue, 27 Oct 2009 17:59:28 +0100	[thread overview]
Message-ID: <4AE726F0.9010800@redhat.com> (raw)
In-Reply-To: <20091027152849.F37C439742@ochil.suse.de>

   Hi,

> +    /* The current Qemu infrastructure allows only for LUN 0 */
> +    if (lun == 0&&  target<  MAX_RAID_DEVS)
> +	cmd->lun =&s->luns[target];

One more thing which should be fixed in qemu instead of worked around in 
your driver.  After all even good old parallel scsi knows multiple luns. 
  Guess this is how you end up with 128 scsi devices (16 ids with 8 luns 
each)?

cheers,
   Gerd

  parent reply	other threads:[~2009-10-27 16:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27 15:28 [PATCH 2/4] megasas: LSI MegaRAID SAS HBA emulation Hannes Reinecke
2009-10-27 15:28 ` [Qemu-devel] " Hannes Reinecke
2009-10-27 16:59 ` Gerd Hoffmann
2009-10-27 16:59 ` Gerd Hoffmann [this message]
2009-10-27 16:59   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE726F0.9010800@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hare@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.