'!' as separator for sxp?

[Jim Fehlig <jfehlig@novell.com>]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

I'm trying to determine if '!' is in fact a separator in domain sxp. 
According to is_separator() in tools/python/xen/xend/sxp.py it is

    def is_separator(self, c):
        return self.in_class(c, '{}()<>[]!;')

But '!' is a valid character in domain sxp, e.g.

(vbd
  (protocol x86_64-abi)
  ...
  (mode w!)
  ...
)

With '!' being a separator, mode must be quoted in order to parse the
above sxp config correctly.  I cannot find any other use of '!' in
domain sxp - and certainly no use of it as a separator.

Does anyone know of the use of '!' as a separator?  If not, the attached
patch removes it from is_separator().

Regards,
Jim


    Signed-off-by: Jim Fehlig <jfehlig@novell.com>




[-- Attachment #2: sxp.patch --]
[-- Type: text/x-patch, Size: 453 bytes --]

diff -r c4958b2edaa5 tools/python/xen/xend/sxp.py
--- a/tools/python/xen/xend/sxp.py	Tue Oct 27 12:52:57 2009 +0000
+++ b/tools/python/xen/xend/sxp.py	Tue Oct 27 15:23:37 2009 -0600
@@ -142,7 +142,7 @@
         return self.in_class(c, ' \t\n\v\f\r')
 
     def is_separator(self, c):
-        return self.in_class(c, '{}()<>[]!;')
+        return self.in_class(c, '{}()<>[];')
 
     def in_comment_class(self, c):
         return self.in_class(c, '#')

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel