[Qemu-devel] Re: [RFC 0/7] QError v1

[Paolo Bonzini <pbonzini@redhat.com>]

>   A last note: this series is on top of the (to be merged) QJSon module,
> that's why it's a RFC and.. I didn't test it too much. :)

I have just two comments:

1) you do

> -        qemu_error("Device \"%s\" not found.  Try -device '?' for a list.\n",
> -                   driver);
> +        qemu_error_structed(QERR_DEV_NFOUND, "{ 'name': %s }", driver);

why not store the "{ 'name': %s }" in the qerror_table?  I guess you 
plan to have different fields in some cases?

2) as I understood it, the consensus was to store the expanded error 
message (i.e. qerror_print) in the JSON output as well.  That would 
involve returning a QString from qerror_print, I guess.

Paolo