From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Han, Weidong" <weidong.han@intel.com>
Cc: "'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>,
"'keir.fraser@eu.citrix.com'" <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH][RFC] pv-ops: fix shared irq device passthrough
Date: Thu, 29 Oct 2009 15:56:02 -0700 [thread overview]
Message-ID: <4AEA1D82.8060609@goop.org> (raw)
In-Reply-To: <715D42877B251141A38726ABF5CABF2C05509A7C3A@pdsmsx503.ccr.corp.intel.com>
On 10/26/09 18:32, Han, Weidong wrote:
>> Hm, not sure about this. The logic in __setup_irq already looks
>> pretty tortured, and I'd like to avoid touching it unless there's
>> definitively a bug in there.
>>
>> I think the right question is whether probe_irq() is really doing the
>> right test, and whether it could do something else instead?
>>
> Totally agree. The better way is to change probe_irq, therefore needn't touch kernel irq stuffs. probe_irq is just check if desc->action == NULL or not. The code is there for a long long time (from c/s 26 in linux-2.6.18-xen.hg). I don't know whether it can be replaced.
>
Could you look into it? How many drivers do interrupt probing these
days anyway? I think we can safely not support ISA devices.
J
next prev parent reply other threads:[~2009-10-29 22:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 11:39 [PATCH][RFC] pv-ops: fix shared irq device passthrough Han, Weidong
2009-10-26 20:27 ` Jeremy Fitzhardinge
2009-10-27 1:32 ` Han, Weidong
2009-10-29 22:56 ` Jeremy Fitzhardinge [this message]
2009-10-30 9:29 ` Han, Weidong
2009-10-30 21:34 ` Jeremy Fitzhardinge
2009-10-31 13:50 ` Han, Weidong
[not found] ` <715D42877B251141A38726ABF5CABF2C055064A406@pdsmsx503.ccr.corp.intel.com>
2009-11-02 10:12 ` Han, Weidong
2009-11-10 6:12 ` Han, Weidong
2009-11-10 6:30 ` Mr. Teo En Ming (Zhang Enming)
2009-11-10 6:59 ` Han, Weidong
2009-11-10 16:30 ` Konrad Rzeszutek Wilk
2009-11-10 17:11 ` Kay, Allen M
2009-11-10 18:40 ` Konrad Rzeszutek Wilk
2009-11-10 18:44 ` Jeremy Fitzhardinge
2009-11-12 7:15 ` Han, Weidong
2009-11-10 17:56 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEA1D82.8060609@goop.org \
--to=jeremy@goop.org \
--cc=keir.fraser@eu.citrix.com \
--cc=weidong.han@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.