How to use patchwork?

How to use patchwork?

[Steffen Sledz]

In the last days i had to patch suggestions concerning common recipes
(glibc and busybox). That's why i planned to introduce them via the
patchwork queue.

I prepared them with "git format-patch" and sent them using "git
send-email" to openembedded-devel@lists.openembedded.org. They were
sent to the list but did not reach patchwork. :(

So i believe i did something wrong. But what? Unfortunately the wiki
is not very helpful here.

Steffen

Re: How to use patchwork?

[Holger Hans Peter Freyther]

On Thursday 29 October 2009 14:04:04 Steffen Sledz wrote:
> In the last days i had to patch suggestions concerning common recipes
> (glibc and busybox). That's why i planned to introduce them via the
> patchwork queue.
> 
> I prepared them with "git format-patch" and sent them using "git
> send-email" to openembedded-devel@lists.openembedded.org. They were
> sent to the list but did not reach patchwork. :(
> 
> So i believe i did something wrong. But what? Unfortunately the wiki
> is not very helpful here.

Did you have a "Signed-off-by: " line in it?

z.

Re: How to use patchwork?

[Steffen Sledz]

Holger Hans Peter Freyther wrote:
> On Thursday 29 October 2009 14:04:04 Steffen Sledz wrote:
>> In the last days i had to patch suggestions concerning common recipes
>> (glibc and busybox). That's why i planned to introduce them via the
>> patchwork queue.
>>
>> I prepared them with "git format-patch" and sent them using "git
>> send-email" to openembedded-devel@lists.openembedded.org. They were
>> sent to the list but did not reach patchwork. :(
>>
>> So i believe i did something wrong. But what? Unfortunately the wiki
>> is not very helpful here.
> 
> Did you have a "Signed-off-by: " line in it?

Yep, see e.g.
<http://thread.gmane.org/gmane.comp.handhelds.openembedded/26999>

Re: How to use patchwork?

[Martyn Welch]

Steffen Sledz wrote:
> Holger Hans Peter Freyther wrote:
>   
>> On Thursday 29 October 2009 14:04:04 Steffen Sledz wrote:
>>     
>>> In the last days i had to patch suggestions concerning common recipes
>>> (glibc and busybox). That's why i planned to introduce them via the
>>> patchwork queue.
>>>
>>> I prepared them with "git format-patch" and sent them using "git
>>> send-email" to openembedded-devel@lists.openembedded.org. They were
>>> sent to the list but did not reach patchwork. :(
>>>
>>> So i believe i did something wrong. But what? Unfortunately the wiki
>>> is not very helpful here.
>>>       
>> Did you have a "Signed-off-by: " line in it?
>>     
>
> Yep, see e.g.
> <http://thread.gmane.org/gmane.comp.handhelds.openembedded/26999>
>   
At a guess it's because your "Signed-off-by:" line has an obscured email 
address in it.

Martyn

-- 
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,        |Registered in England and Wales
Tove Valley Business Park, Towcester,      |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 927559189

Re: How to use patchwork?

[Steffen Sledz]

On 10/30/2009 09:34 AM, Martyn Welch wrote:
>>> Did you have a "Signed-off-by: " line in it?
>>>     
>>
>> Yep, see e.g.
>> <http://thread.gmane.org/gmane.comp.handhelds.openembedded/26999>
>>   
> At a guess it's because your "Signed-off-by:" line has an obscured email
> address in it.

If you mean

  Signed-off-by: Steffen Sledz <sledz <at> dresearch.de>

this is just a modification of GMANE web interface. In the original
message it was

  Signed-off-by: Steffen Sledz <sledz@dresearch.de>

That should be OK. Or not?

Steffen

Re: How to use patchwork?

[Martyn Welch]

Steffen Sledz wrote:
> On 10/30/2009 09:34 AM, Martyn Welch wrote:
>   
>>>> Did you have a "Signed-off-by: " line in it?
>>>>     
>>>>         
>>> Yep, see e.g.
>>> <http://thread.gmane.org/gmane.comp.handhelds.openembedded/26999>
>>>   
>>>       
>> At a guess it's because your "Signed-off-by:" line has an obscured email
>> address in it.
>>     
>
> If you mean
>
>   Signed-off-by: Steffen Sledz <sledz <at> dresearch.de>
>
> this is just a modification of GMANE web interface. In the original
> message it was
>
>   Signed-off-by: Steffen Sledz <sledz@dresearch.de>
>
> That should be OK. Or not?
>   
Ah, as far as I know that should be OK,

Martyn

-- 
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,        |Registered in England and Wales
Tove Valley Business Park, Towcester,      |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 927559189