From: Boaz Harrosh <bharrosh@panasas.com>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h
Date: Sun, 01 Nov 2009 12:15:27 +0200 [thread overview]
Message-ID: <4AED5FBF.6020308@panasas.com> (raw)
In-Reply-To: <20091031093337.GA3339@deprecation.cyrius.com>
On 10/31/2009 11:33 AM, Martin Michlmayr wrote:
> include/scsi/osd_protocol.h is missing an #include, leading to:
> | include/scsi/osd_protocol.h:277: error: implicit declaration of function '__constant_cpu_to_be16'
> | include/scsi/osd_protocol.h:362: error: implicit declaration of function 'ALIGN'
>
I cannot reproduce this problem. What platform (ARCH/config) are you compiling
this?
Because you see I have a source file in the tree that has this #include as very
first include. And it has been compiling in Kernel and in -next for a long time.
(drivers/scsi/osd/osd_initiator.c has osd_initiator.h as first header which has
osd_protocol.h as first header.)
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
>
> --- a/include/scsi/osd_protocol.h 2009-10-31 09:19:28.000000000 +0000
> +++ b/include/scsi/osd_protocol.h 2009-10-31 09:27:42.000000000 +0000
> @@ -17,6 +17,7 @@
> #define __OSD_PROTOCOL_H__
>
> #include <linux/types.h>
> +#include <linux/kernel.h>
> #include <asm/unaligned.h>
>From what I can see, asm/unaligned.h eventually pulls kernel.h through
one of it's possible implementations. Do you have a special asm/unaligned.h?
> #include <scsi/scsi.h>
>
>
Please help me reproduce this problem.
Boaz
next prev parent reply other threads:[~2009-11-01 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 9:33 [PATCH] Add missing #include for include/scsi/osd_protocol.h Martin Michlmayr
2009-11-01 10:15 ` Boaz Harrosh [this message]
2009-11-01 10:54 ` Martin Michlmayr
2009-11-01 11:25 ` Boaz Harrosh
2009-11-01 11:52 ` Stephen Rothwell
2009-11-01 13:11 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AED5FBF.6020308@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.