From: Boaz Harrosh <bharrosh@panasas.com>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h
Date: Sun, 01 Nov 2009 13:25:43 +0200 [thread overview]
Message-ID: <4AED7037.1080509@panasas.com> (raw)
In-Reply-To: <20091101105416.GN20819@deprecation.cyrius.com>
On 11/01/2009 12:54 PM, Martin Michlmayr wrote:
> * Boaz Harrosh <bharrosh@panasas.com> [2009-11-01 12:15]:
>>> include/scsi/osd_protocol.h is missing an #include, leading to:
>>> | include/scsi/osd_protocol.h:277: error: implicit declaration of function '__constant_cpu_to_be16'
>>> | include/scsi/osd_protocol.h:362: error: implicit declaration of function 'ALIGN'
>>
>> I cannot reproduce this problem. What platform (ARCH/config) are you compiling
>> this?
>
> Sorry, I forgot to say that this happens on ARM.
Yes I can see now linux/unaligned/le_byteshift.h and linux/unaligned/be_byteshift.h look
broken, they do not include headers who's definitions are used. All the other alternatives
in linux/unaligned/ ,example access_ok.h, do. Sigh
But one thing I do not understand, in linux-next is there not a single ARM platform that
does a "make allmodconfig". (Or they do but the compilation error was never reported?)
ACK-by: Boaz Harrosh <bharrosh@panasas.com>
next prev parent reply other threads:[~2009-11-01 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 9:33 [PATCH] Add missing #include for include/scsi/osd_protocol.h Martin Michlmayr
2009-11-01 10:15 ` Boaz Harrosh
2009-11-01 10:54 ` Martin Michlmayr
2009-11-01 11:25 ` Boaz Harrosh [this message]
2009-11-01 11:52 ` Stephen Rothwell
2009-11-01 13:11 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AED7037.1080509@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.