All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: npiggin@suse.de, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 1/1] MM: slqb, fix per_cpu access
Date: Mon, 02 Nov 2009 05:22:58 +0100	[thread overview]
Message-ID: <4AEE5EA2.6010905@kernel.org> (raw)
In-Reply-To: <1257113578-1584-1-git-send-email-jirislaby@gmail.com>

Hello,

Jiri Slaby wrote:
> @@ -2770,16 +2770,16 @@ static DEFINE_PER_CPU(struct delayed_work, cache_trim_work);

How about renaming cache_trim_work to slqb_cache_trim_work?  Another
percpu name requirement is global uniqueness (for s390 and alpha
support), so prefixing perpcu variables with subsystem name usually
resolves situations like this better.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: npiggin@suse.de, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 1/1] MM: slqb, fix per_cpu access
Date: Mon, 02 Nov 2009 05:22:58 +0100	[thread overview]
Message-ID: <4AEE5EA2.6010905@kernel.org> (raw)
In-Reply-To: <1257113578-1584-1-git-send-email-jirislaby@gmail.com>

Hello,

Jiri Slaby wrote:
> @@ -2770,16 +2770,16 @@ static DEFINE_PER_CPU(struct delayed_work, cache_trim_work);

How about renaming cache_trim_work to slqb_cache_trim_work?  Another
percpu name requirement is global uniqueness (for s390 and alpha
support), so prefixing perpcu variables with subsystem name usually
resolves situations like this better.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-11-02  4:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01 22:12 [PATCH 1/1] MM: slqb, fix per_cpu access Jiri Slaby
2009-11-01 22:12 ` Jiri Slaby
2009-11-02  4:22 ` Tejun Heo [this message]
2009-11-02  4:22   ` Tejun Heo
2009-11-02  8:49   ` Jiri Slaby
2009-11-02  8:49     ` Jiri Slaby
2009-11-02 11:48     ` Dave Young
2009-11-02 11:48       ` Dave Young
2009-11-02 15:24     ` Tejun Heo
2009-11-02 15:24       ` Tejun Heo
2009-11-02 16:24     ` Christoph Lameter
2009-11-02 16:24       ` Christoph Lameter
2009-11-02 13:23 ` Rusty Russell
2009-11-02 13:23   ` Rusty Russell
2009-11-02 15:31   ` Jiri Slaby
2009-11-02 15:31     ` Jiri Slaby
2009-11-04  7:45     ` Rusty Russell
2009-11-04  7:45       ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AEE5EA2.6010905@kernel.org \
    --to=tj@kernel.org \
    --cc=cl@linux-foundation.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.