* [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one
@ 2009-10-27 19:11 Ramsay Jones
2009-11-03 7:22 ` Johannes Sixt
0 siblings, 1 reply; 3+ messages in thread
From: Ramsay Jones @ 2009-10-27 19:11 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list, Marius Storm-Olsen, dpotapov
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
I can't think of any potential problems with this... but I've
added Dmitry to the cc-list, since he appears to have added
the second cygwin section in adbc0b6b, just in case... ;-)
ATB,
Ramsay Jones
Makefile | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index fea237b..8e1cfc5 100644
--- a/Makefile
+++ b/Makefile
@@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)
NO_MMAP = YesPlease
NO_IPV6 = YesPlease
X = .exe
+ COMPAT_OBJS += compat/cygwin.o
+ UNRELIABLE_FSTAT = UnfortunatelyYes
endif
ifeq ($(uname_S),FreeBSD)
NEEDS_LIBICONV = YesPlease
@@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)
NO_SYS_SELECT_H = YesPlease
SNPRINTF_RETURNS_BOGUS = YesPlease
endif
-ifneq (,$(findstring CYGWIN,$(uname_S)))
- COMPAT_OBJS += compat/cygwin.o
- UNRELIABLE_FSTAT = UnfortunatelyYes
-endif
ifdef MSVC
GIT_VERSION := $(GIT_VERSION).MSVC
pathsep = ;
--
1.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one
2009-10-27 19:11 [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one Ramsay Jones
@ 2009-11-03 7:22 ` Johannes Sixt
2009-11-03 7:46 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Sixt @ 2009-11-03 7:22 UTC (permalink / raw)
To: Ramsay Jones
Cc: Junio C Hamano, GIT Mailing-list, Marius Storm-Olsen, dpotapov
Ramsay Jones schrieb:
> diff --git a/Makefile b/Makefile
> index fea237b..8e1cfc5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)
> NO_MMAP = YesPlease
> NO_IPV6 = YesPlease
> X = .exe
> + COMPAT_OBJS += compat/cygwin.o
> + UNRELIABLE_FSTAT = UnfortunatelyYes
> endif
> ifeq ($(uname_S),FreeBSD)
> NEEDS_LIBICONV = YesPlease
> @@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)
> NO_SYS_SELECT_H = YesPlease
> SNPRINTF_RETURNS_BOGUS = YesPlease
> endif
> -ifneq (,$(findstring CYGWIN,$(uname_S)))
> - COMPAT_OBJS += compat/cygwin.o
> - UNRELIABLE_FSTAT = UnfortunatelyYes
> -endif
> ifdef MSVC
> GIT_VERSION := $(GIT_VERSION).MSVC
> pathsep = ;
I think this an obviously good change even outside this series.
-- Hannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one
2009-11-03 7:22 ` Johannes Sixt
@ 2009-11-03 7:46 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2009-11-03 7:46 UTC (permalink / raw)
To: Johannes Sixt
Cc: Ramsay Jones, Junio C Hamano, GIT Mailing-list,
Marius Storm-Olsen, dpotapov
Johannes Sixt <j.sixt@viscovery.net> writes:
> Ramsay Jones schrieb:
>> diff --git a/Makefile b/Makefile
>> index fea237b..8e1cfc5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)
>> NO_MMAP = YesPlease
>> NO_IPV6 = YesPlease
>> X = .exe
>> + COMPAT_OBJS += compat/cygwin.o
>> + UNRELIABLE_FSTAT = UnfortunatelyYes
>> endif
>> ifeq ($(uname_S),FreeBSD)
>> NEEDS_LIBICONV = YesPlease
>> @@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)
>> NO_SYS_SELECT_H = YesPlease
>> SNPRINTF_RETURNS_BOGUS = YesPlease
>> endif
>> -ifneq (,$(findstring CYGWIN,$(uname_S)))
>> - COMPAT_OBJS += compat/cygwin.o
>> - UNRELIABLE_FSTAT = UnfortunatelyYes
>> -endif
>> ifdef MSVC
>> GIT_VERSION := $(GIT_VERSION).MSVC
>> pathsep = ;
>
> I think this an obviously good change even outside this series.
Thanks; I think this one makes sense.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-03 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-27 19:11 [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one Ramsay Jones
2009-11-03 7:22 ` Johannes Sixt
2009-11-03 7:46 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.