From: Uwe Menges <uwe.menges@web.de>
To: Ludwig Nussel <ludwig.nussel@suse.de>
Cc: dm-crypt@saout.de
Subject: Re: [dm-crypt] [PATCH] print warning when adding a key that contains non-ASCII characters
Date: Tue, 03 Nov 2009 23:40:01 +0100 [thread overview]
Message-ID: <4AF0B141.8050609@web.de> (raw)
In-Reply-To: <20091103084749.21a94a09@tanana.suse.de>
Ludwig Nussel wrote:
> Any opinions?
Your patch uses the isascii() call, but the problem "different keymap at
different password entering times" is IMHO not really related to the
question "is the character ascii or not". It's all too easy to run into
exact the same situation you want to prevent, with just plain ascii
chars in the password.
Yours, Uwe
next prev parent reply other threads:[~2009-11-03 22:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 14:16 [dm-crypt] [PATCH] print warning when adding a key that contains non-ASCII characters Ludwig Nussel
2009-11-03 7:47 ` Ludwig Nussel
2009-11-03 9:15 ` Ian McDonald
2009-11-03 12:58 ` Arno Wagner
2009-11-03 22:40 ` Uwe Menges [this message]
2009-11-04 15:46 ` Heinz Diehl
2009-11-03 9:04 ` Milan Broz
2009-11-03 10:08 ` Ludwig Nussel
2009-11-03 10:31 ` Milan Broz
2009-11-06 11:11 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF0B141.8050609@web.de \
--to=uwe.menges@web.de \
--cc=dm-crypt@saout.de \
--cc=ludwig.nussel@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.