* tmscsim: Missing parentheses in dc390_init_hw()?
@ 2009-11-03 22:55 Roel Kluin
2009-11-03 23:07 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-11-03 22:55 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi
Same oddness, are there parentheses missing here?
Thanks, Roel
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index 9a42734..25e6d63 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2408,8 +2408,8 @@ static void __devinit dc390_init_hw(struct dc390_acb *pACB, u8 index)
/* Negation */
DC390_write8(CtrlReg4, pACB->glitch_cfg | /* glitch eater */
- (dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
- NEGATE_REQACKDATA : 0);
+ ((dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
+ NEGATE_REQACKDATA : 0));
/* Clear Transfer Count High: ID */
DC390_write8(CtcReg_High, 0);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: tmscsim: Missing parentheses in dc390_init_hw()?
2009-11-03 22:55 tmscsim: Missing parentheses in dc390_init_hw()? Roel Kluin
@ 2009-11-03 23:07 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2009-11-03 23:07 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-scsi
On Tue, 2009-11-03 at 23:55 +0100, Roel Kluin wrote:
> Same oddness, are there parentheses missing here?
>
> Thanks, Roel
>
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
> index 9a42734..25e6d63 100644
> --- a/drivers/scsi/tmscsim.c
> +++ b/drivers/scsi/tmscsim.c
> @@ -2408,8 +2408,8 @@ static void __devinit dc390_init_hw(struct dc390_acb *pACB, u8 index)
>
> /* Negation */
> DC390_write8(CtrlReg4, pACB->glitch_cfg | /* glitch eater */
> - (dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
> - NEGATE_REQACKDATA : 0);
> + ((dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
> + NEGATE_REQACKDATA : 0));
This one looks more possible ... but given it's hw init, the original
meaning is also possible ... and supported by the fact that the hw
works.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-03 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-03 22:55 tmscsim: Missing parentheses in dc390_init_hw()? Roel Kluin
2009-11-03 23:07 ` James Bottomley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.