[Xenomai-core] [PATCH] bug found in psos queue

[Xenomai-core] [PATCH] bug found in psos queue

[Alexandre Coffignal]

Hello all,

I found a bug in xenomai-2.4/src/skins/psos+/queue.c,
in function q_vreceive, struct modifier is not corectly fill with
argument data.

Here the patch to fix this bug

regards,

Alexandre

diff --git a/CREDITS b/CREDITS
index f2ce6ca..6342a8c 100644
--- a/CREDITS
+++ b/CREDITS
@@ -142,3 +142,7 @@ D: Autoconf-related fixes.
 N: Frederic Villeneuve
 E: frederic.villeneuve@domain.hid
 D: udev support for message pipes.
+
+N: Alexandre Coffignal
+E: alexandre.coffignal@domain.hid
+D: psos skin q_vreceive bug fix
diff --git a/src/skins/psos+/queue.c b/src/skins/psos+/queue.c
index 228f5bd..c54f966 100644
--- a/src/skins/psos+/queue.c
+++ b/src/skins/psos+/queue.c
@@ -82,6 +82,10 @@ u_long q_vreceive(u_long qid, u_long flags, u_long
timeout,
                u_long flags;
                u_long timeout;
        } modifiers;    /* Combine to fit into available arg space (i.e.
5) */
+
+       modifiers.flags=flags;
+       modifiers.timeout=timeout;
+
        return XENOMAI_SKINCALL5(__psos_muxid, __psos_q_vreceive,
                                 qid, &modifiers, msgbuf_r, buflen,
msglen_r);
 }


-- 
Alexandre COFFIGNAL, Chef de Projet
Email: alexandre.coffignal[@]cenosys.com
<mailto:alexandre.coffignal@domain.hid>
------------------------------------

10, Rue Xavier Bichat
F-72000 Le MANS
web : http://www.cenosys.com
------------------------------------

Re: [Xenomai-core] [PATCH] bug found in psos queue

[Gilles Chanteperdrix]

Alexandre Coffignal wrote:
> Hello all,
> 
> I found a bug in xenomai-2.4/src/skins/psos+/queue.c,
> in function q_vreceive, struct modifier is not corectly fill with
> argument data.
> 
> Here the patch to fix this bug

Thanks for the patch. But we can not accept a patch of the CREDITS file:
appear in this file people which do contribute regularly. However, if
you send a patch in the usual git format (as produced by
git-format-patch), the patch will be credited to you in the git logs.

So, please resend.
Regard.

-- 
                                          Gilles

Re: [Xenomai-core] [PATCH] bug found in psos queue

[Alexandre Coffignal]

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

Gilles Chanteperdrix a écrit :
> Alexandre Coffignal wrote:
>   
>> Hello all,
>>
>> I found a bug in xenomai-2.4/src/skins/psos+/queue.c,
>> in function q_vreceive, struct modifier is not corectly fill with
>> argument data.
>>
>> Here the patch to fix this bug
>>     
>
> Thanks for the patch. But we can not accept a patch of the CREDITS file:
> appear in this file people which do contribute regularly. However, if
> you send a patch in the usual git format (as produced by
> git-format-patch), the patch will be credited to you in the git logs.
>
> So, please resend.
> Regard.
>
>   
No problem,

Here patch as produced by git-format-patch.

Thank you for your interest,

Regard.

Alexandre


-- 
Alexandre COFFIGNAL, Chef de Projet
Email: alexandre.coffignal@domain.hid
<mailto:alexandre.coffignal@domain.hid>
------------------------------------
CénoSYS <http://www.cenosys.com>
10, Rue Xavier Bichat
F-72000 Le MANS
Tel: +33(0) 243 511 797
web : http://www.cenosys.com
------------------------------------
CONFIDENTIALITE : Ce message électronique et tous les fichiers attachés
qu'il contient sont confidentiels et destinés exclusivement à l'usage de
la personne à laquelle ils sont adressés. Si vous avez reçu ce message
par erreur, merci de le retourner immédiatement a son émetteur sans en
conserver de copie.

CONFIDENTIALITY : This e-mail and any attachments are confidential and
may also be privileged. If you are not the named recipient, please
notify the sender immediately and do not disclose the contents to an
other person, use it for any purpose, or store or copy the information
in any medium.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-psos-in-function-q_vreceive-struct-modifier-is-not.patch --]
[-- Type: text/x-patch; name="0001-psos-in-function-q_vreceive-struct-modifier-is-not.patch", Size: 892 bytes --]

From fed6cef9000904312f886db8b8986f87c444275f Mon Sep 17 00:00:00 2001
From: Alexandre Coffignal <alexandre.coffignal@cenosys.com>
Date: Wed, 4 Nov 2009 13:47:44 +0100
Subject: [PATCH] psos: in function q_vreceive, struct modifier is not corectly fill with
 argument data.

---
 src/skins/psos+/queue.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/skins/psos+/queue.c b/src/skins/psos+/queue.c
index 228f5bd..aa574c3 100644
--- a/src/skins/psos+/queue.c
+++ b/src/skins/psos+/queue.c
@@ -82,6 +82,10 @@ u_long q_vreceive(u_long qid, u_long flags, u_long timeout,
 		u_long flags;
 		u_long timeout;
 	} modifiers;	/* Combine to fit into available arg space (i.e. 5) */
+
+	modifiers.flags=flags;
+	modifiers.timeout=timeout;
+
 	return XENOMAI_SKINCALL5(__psos_muxid, __psos_q_vreceive,
 				 qid, &modifiers, msgbuf_r, buflen, msglen_r);
 }
-- 
1.6.0.4