From: "Yang, Xiaowei" <xiaowei.yang@intel.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: RE: [PATCH] ioemu: fix drive name parsing
Date: Thu, 05 Nov 2009 18:08:05 +0800 [thread overview]
Message-ID: <4AF2A405.9090404@intel.com> (raw)
In-Reply-To: <4AF27686.4020100@intel.com>
> Yang, Xiaowei writes ("[Xen-devel] [PATCH] ioemu: fix drive name parsing"):
> > In xenstore_parse_domain_config(), 'any_hdN' is overridden by local version
> > accidentally.
>
> Thanks for spotting this. You're right that it's a bug. I've applied
> your patch (although really I think this whole area is pretty grotty
> and could do with substantial rework).
>
> Two comments though about the formatting of your patch:
>
> * It didn't apply cleanly because it had different whitespace to
> that in the actual code. Your mailer must have done something to
There must be something wrong when I did the paste.
> it I think. Best practice seems to be (if you can't make your
> mailer reliably not mangle the body of the message) to provide each
> patch _both_ as an attachment (for application) _and_ by including
> it in the body (for readable review).
Thanks for the advice. I'll attach the patch also next time.
>
> * You forgot the Signed-off-By line, by which you would certify that
I added the signed-off-by line at the bottom!:)
Thanks,
xiaowei
> the code copyright and so forth status was appropriate (according
> to the Developer's Certificate of Origin). I applied your patch
> anyway because it's a one-line change (which most authorities think
> makes it too small for copyright to apply) but you should make sure
> to appropriately certify your code in future.
>
next parent reply other threads:[~2009-11-05 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AF27686.4020100@intel.com>
2009-11-05 10:08 ` Yang, Xiaowei [this message]
2009-11-05 11:51 ` [PATCH] ioemu: fix drive name parsing Ian Jackson
2009-11-04 7:52 Yang, Xiaowei
2009-11-04 17:12 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF2A405.9090404@intel.com \
--to=xiaowei.yang@intel.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.