All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] irq: remove __weak early_irq_init()
@ 2009-11-06  6:00 Yong Zhang
  2009-11-06  6:08 ` Yinghai Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Yong Zhang @ 2009-11-06  6:00 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ingo Molnar, Thomas Gleixner, Yinghai Lu

>From 86a53664e3f503fe06b166fb248ed64a77212b3d Mon Sep 17 00:00:00 2001
From: Yong Zhang <yong.zhang0@gmail.com>
Date: Fri, 6 Nov 2009 13:53:30 +0800
Subject: [PATCH] irq: remove __weak early_irq_init()

impact: cleanup

Since commit 12026ea16a618b289fcf457661aed24f57323a20
early_irq_init() is always defined in kernel/irq/handle.c
So remove the weak definition.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
 kernel/softirq.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index f8749e5..5e881e3 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -886,11 +886,6 @@ EXPORT_SYMBOL(on_each_cpu);
  *   GCC does not inline them incorrectly. ]
  */

-int __init __weak early_irq_init(void)
-{
-	return 0;
-}
-
 int __init __weak arch_probe_nr_irqs(void)
 {
 	return 0;
-- 
1.6.3.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] irq: remove __weak early_irq_init()
  2009-11-06  6:00 [PATCH] irq: remove __weak early_irq_init() Yong Zhang
@ 2009-11-06  6:08 ` Yinghai Lu
  2009-11-06  6:51   ` Yong Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2009-11-06  6:08 UTC (permalink / raw)
  To: Yong Zhang; +Cc: linux-kernel, Ingo Molnar, Thomas Gleixner

Yong Zhang wrote:
>>From 86a53664e3f503fe06b166fb248ed64a77212b3d Mon Sep 17 00:00:00 2001
> From: Yong Zhang <yong.zhang0@gmail.com>
> Date: Fri, 6 Nov 2009 13:53:30 +0800
> Subject: [PATCH] irq: remove __weak early_irq_init()
> 
> impact: cleanup
> 
> Since commit 12026ea16a618b289fcf457661aed24f57323a20
> early_irq_init() is always defined in kernel/irq/handle.c
> So remove the weak definition.

some arches that do not have GENERIC_HARDIRQS defined need that.

YH

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] irq: remove __weak early_irq_init()
  2009-11-06  6:08 ` Yinghai Lu
@ 2009-11-06  6:51   ` Yong Zhang
  0 siblings, 0 replies; 3+ messages in thread
From: Yong Zhang @ 2009-11-06  6:51 UTC (permalink / raw)
  To: Yinghai Lu; +Cc: linux-kernel, Ingo Molnar, Thomas Gleixner

On Fri, Nov 6, 2009 at 2:08 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> Yong Zhang wrote:
>>>From 86a53664e3f503fe06b166fb248ed64a77212b3d Mon Sep 17 00:00:00 2001
>> From: Yong Zhang <yong.zhang0@gmail.com>
>> Date: Fri, 6 Nov 2009 13:53:30 +0800
>> Subject: [PATCH] irq: remove __weak early_irq_init()
>>
>> impact: cleanup
>>
>> Since commit 12026ea16a618b289fcf457661aed24f57323a20
>> early_irq_init() is always defined in kernel/irq/handle.c
>> So remove the weak definition.
>
> some arches that do not have GENERIC_HARDIRQS defined need that.
>

Thanks for your point. I just notice kernel/irq is determined by
GENERIC_HARDIRQS.

-Yong

> YH
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-06  6:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-06  6:00 [PATCH] irq: remove __weak early_irq_init() Yong Zhang
2009-11-06  6:08 ` Yinghai Lu
2009-11-06  6:51   ` Yong Zhang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.