From: Gerd Hoffmann <kraxel@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [sneak preview] major scsi overhaul
Date: Mon, 09 Nov 2009 10:08:18 +0100 [thread overview]
Message-ID: <4AF7DC02.2070308@redhat.com> (raw)
In-Reply-To: <f43fc5580911070722n415ea07cr63c2816263234df@mail.gmail.com>
On 11/07/09 16:22, Blue Swirl wrote:
> In general the commits look good, there are many obviously correct cleanups.
>
> However, what happens to the DPRINTFs, it looks like they are removed
> in the process?
I guess you are talking about the ones for each emulated command in
scsi-disk.c? There is scsi_print_req() now, filling this hole. I'll
stick in a call, wrapped into #ifdef DEBUG_SCSI, so you'll get this
printed by default when compiling with debugging enabled.
> You are also moving the compilation to Makefile.hw, which is not
> exactly an improvement. Is this needed because of the QEMUIOVector
> stuff?
Almost correct ;)
It is because of QEMUSGList which drags in a target_phys_addr_t dependency.
cheers,
Gerd
next prev parent reply other threads:[~2009-11-09 9:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 23:09 [Qemu-devel] [sneak preview] major scsi overhaul Gerd Hoffmann
2009-11-07 15:22 ` Blue Swirl
2009-11-09 9:08 ` Gerd Hoffmann [this message]
2009-11-09 12:37 ` Avi Kivity
2009-11-09 13:03 ` Gerd Hoffmann
2009-11-09 13:17 ` Avi Kivity
2009-11-09 13:39 ` Gerd Hoffmann
2009-11-09 13:48 ` Avi Kivity
2009-11-09 20:38 ` Blue Swirl
2009-11-09 21:25 ` Gerd Hoffmann
2009-11-11 4:06 ` Paul Brook
2009-11-11 9:41 ` Gerd Hoffmann
2009-11-11 14:13 ` Paul Brook
2009-11-11 15:26 ` Gerd Hoffmann
2009-11-11 16:38 ` Paul Brook
2009-11-16 16:35 ` Gerd Hoffmann
2009-11-16 18:53 ` Paul Brook
2009-11-16 21:50 ` Gerd Hoffmann
2009-11-24 11:59 ` Gerd Hoffmann
2009-11-24 13:51 ` Paul Brook
2009-11-25 16:37 ` Gerd Hoffmann
2009-11-26 7:31 ` Hannes Reinecke
2009-11-26 8:25 ` Gerd Hoffmann
2009-11-26 10:57 ` Hannes Reinecke
2009-11-26 11:04 ` Gerd Hoffmann
2009-11-26 11:20 ` Hannes Reinecke
2009-11-26 14:21 ` Gerd Hoffmann
2009-11-26 14:27 ` Hannes Reinecke
2009-11-26 14:37 ` Gerd Hoffmann
2009-11-26 15:50 ` Hannes Reinecke
2009-11-27 11:08 ` Gerd Hoffmann
2009-12-02 13:47 ` Gerd Hoffmann
2009-12-07 8:28 ` Hannes Reinecke
2009-12-07 8:50 ` Gerd Hoffmann
2009-11-16 19:08 ` Ryan Harper
2009-11-16 20:40 ` Gerd Hoffmann
2009-11-16 21:45 ` Ryan Harper
2009-11-11 11:21 ` [Qemu-devel] " Gerd Hoffmann
2009-11-11 11:52 ` Hannes Reinecke
2009-11-11 13:02 ` Gerd Hoffmann
2009-11-11 13:30 ` Hannes Reinecke
2009-11-11 14:37 ` Gerd Hoffmann
2009-11-12 9:54 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF7DC02.2070308@redhat.com \
--to=kraxel@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.