From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60
Date: Mon, 09 Nov 2009 10:52:14 +0000 [thread overview]
Message-ID: <4AF7F45E.2090705@redhat.com> (raw)
In-Reply-To: <20091109113829.204f18fe@hyperion.delvare>
Ack.
On 11/09/2009 11:38 AM, Jean Delvare wrote:
> The comment says that limits are cached for 60 seconds but the code
> actually caches them for only 2 seconds. Align the code on the
> comment, as 60 seconds make more sense.
>
> Signed-off-by: Jean Delvare<khali@linux-fr.org>
> Cc: Hans de Goede<hdegoede@redhat.com>
> Cc: Jordan Crouse<jordan@cosmicpenguin.net>
> ---
> drivers/hwmon/adt7475.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.32-rc6.orig/drivers/hwmon/adt7475.c 2009-11-08 19:22:06.000000000 +0100
> +++ linux-2.6.32-rc6/drivers/hwmon/adt7475.c 2009-11-09 10:28:59.000000000 +0100
> @@ -1151,7 +1151,7 @@ static struct adt7475_data *adt7475_upda
> }
>
> /* Limits and settings, should never change update every 60 seconds */
> - if (time_after(jiffies, data->limits_updated + HZ * 2) ||
> + if (time_after(jiffies, data->limits_updated + HZ * 60) ||
> !data->valid) {
> data->config5 = adt7475_read(REG_CONFIG5);
>
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-11-09 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 10:38 [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60 seconds Jean Delvare
2009-11-09 10:52 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF7F45E.2090705@redhat.com \
--to=hdegoede@redhat.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.