* [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60 seconds
@ 2009-11-09 10:38 Jean Delvare
2009-11-09 10:52 ` [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60 Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2009-11-09 10:38 UTC (permalink / raw)
To: lm-sensors
The comment says that limits are cached for 60 seconds but the code
actually caches them for only 2 seconds. Align the code on the
comment, as 60 seconds make more sense.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Jordan Crouse <jordan@cosmicpenguin.net>
---
drivers/hwmon/adt7475.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.32-rc6.orig/drivers/hwmon/adt7475.c 2009-11-08 19:22:06.000000000 +0100
+++ linux-2.6.32-rc6/drivers/hwmon/adt7475.c 2009-11-09 10:28:59.000000000 +0100
@@ -1151,7 +1151,7 @@ static struct adt7475_data *adt7475_upda
}
/* Limits and settings, should never change update every 60 seconds */
- if (time_after(jiffies, data->limits_updated + HZ * 2) ||
+ if (time_after(jiffies, data->limits_updated + HZ * 60) ||
!data->valid) {
data->config5 = adt7475_read(REG_CONFIG5);
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60
2009-11-09 10:38 [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60 seconds Jean Delvare
@ 2009-11-09 10:52 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2009-11-09 10:52 UTC (permalink / raw)
To: lm-sensors
Ack.
On 11/09/2009 11:38 AM, Jean Delvare wrote:
> The comment says that limits are cached for 60 seconds but the code
> actually caches them for only 2 seconds. Align the code on the
> comment, as 60 seconds make more sense.
>
> Signed-off-by: Jean Delvare<khali@linux-fr.org>
> Cc: Hans de Goede<hdegoede@redhat.com>
> Cc: Jordan Crouse<jordan@cosmicpenguin.net>
> ---
> drivers/hwmon/adt7475.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.32-rc6.orig/drivers/hwmon/adt7475.c 2009-11-08 19:22:06.000000000 +0100
> +++ linux-2.6.32-rc6/drivers/hwmon/adt7475.c 2009-11-09 10:28:59.000000000 +0100
> @@ -1151,7 +1151,7 @@ static struct adt7475_data *adt7475_upda
> }
>
> /* Limits and settings, should never change update every 60 seconds */
> - if (time_after(jiffies, data->limits_updated + HZ * 2) ||
> + if (time_after(jiffies, data->limits_updated + HZ * 60) ||
> !data->valid) {
> data->config5 = adt7475_read(REG_CONFIG5);
>
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-09 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-09 10:38 [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60 seconds Jean Delvare
2009-11-09 10:52 ` [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60 Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.