All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: hollisb@linux.vnet.ibm.com, kvm-ppc <kvm-ppc@vger.kernel.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific
Date: Mon, 09 Nov 2009 23:22:25 +0000	[thread overview]
Message-ID: <4AF8A431.3040607@us.ibm.com> (raw)
In-Reply-To: <4AF893BC.2040507@web.de>

Jan Kiszka wrote:
> Hollis Blanchard wrote:
>   
>> Unbreaks PowerPC and S390 KVM builds.
>>     
>
> What breaks precisely?
>
> Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be
> shared with ia64 - one day. We could still move things back then, but
> maybe we can handle the build issues already in place, specifically as
> qemu-kvm is carrying this in generic code since ages.
>   

mp_state is pretty specific to the in-kernel apic.  ia64 may share 
because it shares an interrupt controller but that does not make it 
generic.  That just makes two architectures have a common field.

I don't think there's anything wrong with kvm exposing this as a common 
ioctl but from a qemu perspective, it makes no sense as a common cpu 
field.  It only makes sense when using kvm and when using an in-kernel 
apic.  That's very architecture specific from an qemu perspective.

-- 
Regards,

Anthony Liguori


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: hollisb@linux.vnet.ibm.com, kvm-ppc <kvm-ppc@vger.kernel.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code
Date: Mon, 09 Nov 2009 17:22:25 -0600	[thread overview]
Message-ID: <4AF8A431.3040607@us.ibm.com> (raw)
In-Reply-To: <4AF893BC.2040507@web.de>

Jan Kiszka wrote:
> Hollis Blanchard wrote:
>   
>> Unbreaks PowerPC and S390 KVM builds.
>>     
>
> What breaks precisely?
>
> Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be
> shared with ia64 - one day. We could still move things back then, but
> maybe we can handle the build issues already in place, specifically as
> qemu-kvm is carrying this in generic code since ages.
>   

mp_state is pretty specific to the in-kernel apic.  ia64 may share 
because it shares an interrupt controller but that does not make it 
generic.  That just makes two architectures have a common field.

I don't think there's anything wrong with kvm exposing this as a common 
ioctl but from a qemu perspective, it makes no sense as a common cpu 
field.  It only makes sense when using kvm and when using an in-kernel 
apic.  That's very architecture specific from an qemu perspective.

-- 
Regards,

Anthony Liguori

  parent reply	other threads:[~2009-11-09 23:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 21:05 [PATCH 0 of 2] Fix PowerPC KVM build breaks Hollis Blanchard
2009-11-09 21:05 ` [Qemu-devel] " Hollis Blanchard
2009-11-09 21:05 ` [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code Hollis Blanchard
2009-11-09 21:05   ` [Qemu-devel] " Hollis Blanchard
2009-11-09 22:12   ` [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific Jan Kiszka
2009-11-09 22:12     ` [Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code Jan Kiszka
2009-11-09 22:21     ` Alexander Graf
2009-11-09 22:21       ` [Qemu-devel] " Alexander Graf
2009-11-09 22:23     ` [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific Hollis Blanchard
2009-11-09 22:23       ` [Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code Hollis Blanchard
2009-11-09 23:03       ` [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific Jan Kiszka
2009-11-09 23:03         ` [Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code Jan Kiszka
2009-11-09 23:22     ` Anthony Liguori [this message]
2009-11-09 23:22       ` Anthony Liguori
2009-11-09 21:05 ` [PATCH 2 of 2] kvm ppc: Remove unused label Hollis Blanchard
2009-11-09 21:05   ` [Qemu-devel] " Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF8A431.3040607@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=hollisb@linux.vnet.ibm.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.