Re: [Xenomai-core] [pull request] heap reference and trivial build fixes

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

Gilles Chanteperdrix wrote:
> Jan Kiszka wrote:
>> Gilles Chanteperdrix wrote:
>>> Jan Kiszka wrote:
>>>> The following changes since commit 6d7d6bc436ef3d1fb51fa8de06d4ecf004e3b6a5:
>>>>   Gilles Chanteperdrix (1):
>>>>         nucleus: defer selector block deletion to an APC.
>>>>
>>>> are available in the git repository at:
>>>>
>>>>   git://git.xenomai.org/xenomai-jki.git for-upstream
>>>>
>>>> Jan Kiszka (2):
>>>>       nucleus: Track heap mapping on to mm-clone
>>>>       nucleus: Fix trivial build warning
>>>>
>>>>  ksrc/nucleus/heap.c   |   12 +++++++++++-
>>>>  ksrc/nucleus/module.c |    2 +-
>>>>  2 files changed, 12 insertions(+), 2 deletions(-)
>>> Hi Jan,
>>>
>>> do you agree if I add the notification to the xenomai-git mailing list
>>> for your tree? It makes it possible to review your patches without any
>>> action on your side. Note that a recent modification to the notification
>>> mechanism only shows the relevant patches.
>>>
>> No problem. Ah, the new filter looks nice!
>>
>> And how would my new workflow look like? Just silently push into
>> 'for-upstream'?
> 
> Well, it does not work for me, because I always realize that I screwed
> up AFTER I push the changes. Besides, we may push things only for
> review, so, I would keep the pull requests and the discussions on the
> list, only avoid publishing the patches manually on the list. But this
> is open for discussion of course.

Fine with me as well, specifically as I tend to face similar problems.
And as one can pick the patches for citing from xenomai-git, commenting
on patching shouldn't be much harder for the reviewer.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]