All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: Len Brown <lenb@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: [PATCH] x86: make sure wakeup code is below 1M -v2
Date: Tue, 10 Nov 2009 18:27:23 -0800	[thread overview]
Message-ID: <4AFA210B.3020207@kernel.org> (raw)
In-Reply-To: <200911091315.13151.rjw@sisk.pl>


try to find_e820_area/reserve_early, and call acpi_reserve_memory early

to get area is below 1M

-v2: change function name to acpi_reserve_wakeup_memory according to Rafael

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/include/asm/acpi.h  |    2 +-
 arch/x86/kernel/acpi/sleep.c |   15 +++++++++------
 arch/x86/kernel/setup.c      |   13 +++++++------
 3 files changed, 17 insertions(+), 13 deletions(-)

Index: linux-2.6/arch/x86/include/asm/acpi.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/acpi.h
+++ linux-2.6/arch/x86/include/asm/acpi.h
@@ -118,7 +118,7 @@ extern void acpi_restore_state_mem(void)
 extern unsigned long acpi_wakeup_address;
 
 /* early initialization routine */
-extern void acpi_reserve_bootmem(void);
+extern void acpi_reserve_wakeup_memory(void);
 
 /*
  * Check if the CPU can handle C2 and deeper
Index: linux-2.6/arch/x86/kernel/acpi/sleep.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/acpi/sleep.c
+++ linux-2.6/arch/x86/kernel/acpi/sleep.c
@@ -119,29 +119,32 @@ void acpi_restore_state_mem(void)
 
 
 /**
- * acpi_reserve_bootmem - do _very_ early ACPI initialisation
+ * acpi_reserve_wakeup_memory - do _very_ early ACPI initialisation
  *
  * We allocate a page from the first 1MB of memory for the wakeup
  * routine for when we come back from a sleep state. The
  * runtime allocator allows specification of <16MB pages, but not
  * <1MB pages.
  */
-void __init acpi_reserve_bootmem(void)
+void __init acpi_reserve_wakeup_memory(void)
 {
+	unsigned long mem;
+
 	if ((&wakeup_code_end - &wakeup_code_start) > WAKEUP_SIZE) {
 		printk(KERN_ERR
 		       "ACPI: Wakeup code way too big, S3 disabled.\n");
 		return;
 	}
 
-	acpi_realmode = (unsigned long)alloc_bootmem_low(WAKEUP_SIZE);
+	mem = find_e820_area(0, 1<<20, WAKEUP_SIZE, PAGE_SIZE);
 
-	if (!acpi_realmode) {
+	if (mem == -1L) {
 		printk(KERN_ERR "ACPI: Cannot allocate lowmem, S3 disabled.\n");
 		return;
 	}
-
-	acpi_wakeup_address = virt_to_phys((void *)acpi_realmode);
+	acpi_realmode = (unsigned long) phys_to_virt(mem);
+	acpi_wakeup_address = mem;
+	reserve_early(mem, mem + WAKEUP_SIZE, "ACPI WAKEUP");
 }
 
 
Index: linux-2.6/arch/x86/kernel/setup.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/setup.c
+++ linux-2.6/arch/x86/kernel/setup.c
@@ -905,6 +905,13 @@ void __init setup_arch(char **cmdline_p)
 
 	reserve_brk();
 
+#ifdef CONFIG_ACPI_SLEEP
+	/*
+	 * Reserve low memory region for sleep support.
+	 * even before init_memory_mapping
+	 */
+	acpi_reserve_wakeup_memory();
+#endif
 	init_gbpages();
 
 	/* max_pfn_mapped is updated here */
@@ -956,12 +963,6 @@ void __init setup_arch(char **cmdline_p)
 
 	initmem_init(0, max_pfn, acpi, k8);
 
-#ifdef CONFIG_ACPI_SLEEP
-	/*
-	 * Reserve low memory region for sleep support.
-	 */
-	acpi_reserve_bootmem();
-#endif
 	/*
 	 * Find and reserve possible boot-time SMP configuration:
 	 */

  parent reply	other threads:[~2009-11-11  2:29 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09  8:51 [RFC PATCH] x86: make sure wakeup code is below 1M Yinghai Lu
2009-11-09 12:15 ` Rafael J. Wysocki
2009-11-11  2:27   ` [PATCH] x86: make sure wakeup code is below 1M -v2 Yinghai Lu
2009-11-11  2:27   ` Yinghai Lu [this message]
2009-11-11  7:48     ` Ingo Molnar
2009-11-11  7:48     ` Ingo Molnar
2009-11-11  7:48       ` Ingo Molnar
2009-11-11  7:57       ` H. Peter Anvin
2009-11-11  7:57       ` H. Peter Anvin
2009-11-11  9:56       ` Rafael J. Wysocki
2009-11-11  9:56       ` Rafael J. Wysocki
2009-11-11  9:12     ` ykzhao
2009-11-11  9:12     ` ykzhao
2009-11-11 19:05       ` Yinghai Lu
2009-11-12  1:17         ` ykzhao
2009-11-12  1:17         ` ykzhao
2009-11-12  3:12           ` Yinghai Lu
2009-11-12  3:12           ` Yinghai Lu
2009-11-12  3:37             ` ykzhao
2009-11-12  3:37             ` ykzhao
2009-11-12  5:21               ` Yinghai Lu
2009-11-12  5:21               ` Yinghai Lu
2009-11-12  7:14                 ` ykzhao
2009-11-12  7:14                 ` ykzhao
2009-11-12  7:20                   ` H. Peter Anvin
2009-11-12  7:20                   ` H. Peter Anvin
2009-11-12  7:43                 ` ykzhao
2009-11-12  7:43                 ` ykzhao
2009-11-11 19:05       ` Yinghai Lu
2009-11-11 20:30     ` [tip:x86/mm] x86: Make sure wakeup trampoline code is below 1MB tip-bot for Yinghai Lu
2009-11-11 20:30     ` tip-bot for Yinghai Lu
2009-11-12  7:36     ` [PATCH] x86: make sure wakeup code is below 1M -v2 Pavel Machek
2009-11-12  7:36       ` Pavel Machek
2009-11-12 19:25       ` Yinghai Lu
2009-11-12 19:25       ` Yinghai Lu
2009-11-12 19:32       ` Rafael J. Wysocki
2009-11-13  7:36         ` Ingo Molnar
2009-11-13  8:04           ` H. Peter Anvin
2009-11-13  8:12             ` Ingo Molnar
2009-11-13  8:12             ` Ingo Molnar
2009-11-13  8:04           ` H. Peter Anvin
2009-11-13  7:36         ` Ingo Molnar
2009-11-12 19:32       ` Rafael J. Wysocki
2009-11-09 12:15 ` [RFC PATCH] x86: make sure wakeup code is below 1M Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFA210B.3020207@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.