From: "H. Peter Anvin" <hpa@zytor.com>
To: ykzhao <yakui.zhao@intel.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>, Len Brown <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] x86: make sure wakeup code is below 1M -v2
Date: Wed, 11 Nov 2009 23:20:15 -0800 [thread overview]
Message-ID: <4AFBB72F.6070907@zytor.com> (raw)
In-Reply-To: <1258010067.3802.11.camel@localhost.localdomain>
On 11/11/2009 11:14 PM, ykzhao wrote:
>
> In this patch the find_e820_area is used in the
> acpi_reserve_wakeup_memory, which is called after initializing the
> bootmem allocator.
> Can we still use the find_e820_area after the bootmem allocator is
> initialized?
Obviously not: the bootmem allocator now thinks it owns memory, and it
wouldn't know not to allocate something that is later claimed by
find_e820_area. Problem.
> It seems that the bootmem bitmap is also found by using the
> find_e820_area. But we don't update the reserved_early array any more.
> Maybe we will get the overlap address with the bootmem bitmap for the
> wakeup code.
Not just the bitmap, but any bootmem allocation could conflict...
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-11-12 7:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 8:51 [RFC PATCH] x86: make sure wakeup code is below 1M Yinghai Lu
2009-11-09 12:15 ` Rafael J. Wysocki
2009-11-11 2:27 ` [PATCH] x86: make sure wakeup code is below 1M -v2 Yinghai Lu
2009-11-11 2:27 ` Yinghai Lu
2009-11-11 7:48 ` Ingo Molnar
2009-11-11 7:48 ` Ingo Molnar
2009-11-11 7:57 ` H. Peter Anvin
2009-11-11 7:57 ` H. Peter Anvin
2009-11-11 9:56 ` Rafael J. Wysocki
2009-11-11 9:56 ` Rafael J. Wysocki
2009-11-11 7:48 ` Ingo Molnar
2009-11-11 9:12 ` ykzhao
2009-11-11 19:05 ` Yinghai Lu
2009-11-12 1:17 ` ykzhao
2009-11-12 3:12 ` Yinghai Lu
2009-11-12 3:37 ` ykzhao
2009-11-12 3:37 ` ykzhao
2009-11-12 5:21 ` Yinghai Lu
2009-11-12 7:14 ` ykzhao
2009-11-12 7:20 ` H. Peter Anvin
2009-11-12 7:20 ` H. Peter Anvin [this message]
2009-11-12 7:14 ` ykzhao
2009-11-12 7:43 ` ykzhao
2009-11-12 7:43 ` ykzhao
2009-11-12 5:21 ` Yinghai Lu
2009-11-12 3:12 ` Yinghai Lu
2009-11-12 1:17 ` ykzhao
2009-11-11 19:05 ` Yinghai Lu
2009-11-11 9:12 ` ykzhao
2009-11-11 20:30 ` [tip:x86/mm] x86: Make sure wakeup trampoline code is below 1MB tip-bot for Yinghai Lu
2009-11-11 20:30 ` tip-bot for Yinghai Lu
2009-11-12 7:36 ` [PATCH] x86: make sure wakeup code is below 1M -v2 Pavel Machek
2009-11-12 7:36 ` Pavel Machek
2009-11-12 19:25 ` Yinghai Lu
2009-11-12 19:25 ` Yinghai Lu
2009-11-12 19:32 ` Rafael J. Wysocki
2009-11-12 19:32 ` Rafael J. Wysocki
2009-11-13 7:36 ` Ingo Molnar
2009-11-13 8:04 ` H. Peter Anvin
2009-11-13 8:04 ` H. Peter Anvin
2009-11-13 8:12 ` Ingo Molnar
2009-11-13 8:12 ` Ingo Molnar
2009-11-13 7:36 ` Ingo Molnar
2009-11-09 12:15 ` [RFC PATCH] x86: make sure wakeup code is below 1M Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFBB72F.6070907@zytor.com \
--to=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=yakui.zhao@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.