All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mac80211: fix broadcast frame handling for 4-addr AP VLANs
@ 2009-11-11 12:17 Felix Fietkau
  0 siblings, 0 replies; only message in thread
From: Felix Fietkau @ 2009-11-11 12:17 UTC (permalink / raw)
  To: linux-wireless; +Cc: Johannes Berg, John W. Linville

Without this patch, broadcast frames from the station behind a
4-addr AP VLAN would be reflected back to the source.
Fix this by checking the 4-addr flag before bridging multicast
frames in the cell.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
I hadn't noticed that v2 of my mac80211 4-addr patch had been
merged already, so here's the fix from v3 as a separate patch

--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -1292,7 +1292,7 @@ ieee80211_deliver_skb(struct ieee80211_r
 	if ((sdata->vif.type == NL80211_IFTYPE_AP ||
 	     sdata->vif.type == NL80211_IFTYPE_AP_VLAN) &&
 	    !(sdata->flags & IEEE80211_SDATA_DONT_BRIDGE_PACKETS) &&
-	    (rx->flags & IEEE80211_RX_RA_MATCH)) {
+	    (rx->flags & IEEE80211_RX_RA_MATCH) && !rx->sdata->use_4addr) {
 		if (is_multicast_ether_addr(ehdr->h_dest)) {
 			/*
 			 * send multicast frames both to higher layers in

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-11-11 12:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-11 12:17 [PATCH] mac80211: fix broadcast frame handling for 4-addr AP VLANs Felix Fietkau

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.