Compile break on SLES10

Compile break on SLES10

[Andre Przywara]

Hi,

changeset 20415 
(http://xenbits.xensource.com/xen-unstable.hg?rev/9479190566fd) breaks 
compilation of tools using older GCCs, like the one provided with SLES10 
(including the recent SP3). This ships with version 4.1.2, which does 
not feature the -fgnu89-inline flag used by this c/s.
According to a more recent manpage this flag was introduced with 4.1.3.

Is the flag really needed for this driver to work?
Can the flag be removed from the Makefile?

Thanks!

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448 3567 12
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd; Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: Compile break on SLES10

[Keir Fraser]

On 11/11/2009 12:47, "Andre Przywara" <andre.przywara@amd.com> wrote:

> changeset 20415 
> (http://xenbits.xensource.com/xen-unstable.hg?rev/9479190566fd) breaks
> compilation of tools using older GCCs, like the one provided with SLES10
> (including the recent SP3). This ships with version 4.1.2, which does
> not feature the -fgnu89-inline flag used by this c/s.
> According to a more recent manpage this flag was introduced with 4.1.3.
> 
> Is the flag really needed for this driver to work?
> Can the flag be removed from the Makefile?

Thanks, fixed by c/s 20425.

 -- Keir