From: Mike Rapoport <mike@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] smc911x: silence MAC mismatch warning
Date: Wed, 11 Nov 2009 18:07:20 +0200 [thread overview]
Message-ID: <4AFAE138.9050504@compulab.co.il> (raw)
In-Reply-To: <200911111022.15096.vapier@gentoo.org>
Mike Frysinger wrote:
> On Wednesday 11 November 2009 03:03:02 Mike Rapoport wrote:
>> If there is no SROM attached to the SMSC chip it's MAC address is
>> initialized to ff:ff:ff:ff:ff:ff and it causes the following
>> warning:
>>
>> Warning: smc911x-0 MAC addresses don't match:
>> Address in SROM is ff:ff:ff:ff:ff:ff
>> Address in environment is 00:01:ba:dc:0d:03
>>
>> Set dev->enetaddr only if MAC address is valid, and thus avoid the
>> above case.
>
> someone already posted a patch for this issue:
> NET: Fix MAC addr handling for smc911x
>
> i think the approach they took is better -- they check for explicit values
> that indicate 'no srom is attached' rather than 'is the mac valid' as your
> code could ignore attached srom's but bad addresses. in this latter case, i
> think we want the warning.
agree
> -mike
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2009-11-11 16:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 8:02 [U-Boot] [PATCH 0/5] smc911x driver fixes and additions Mike Rapoport
2009-11-11 8:03 ` [U-Boot] [PATCH 1/5] smc911x: return -1 when initialization fails Mike Rapoport
2009-11-11 15:16 ` Mike Frysinger
2009-11-12 13:35 ` [U-Boot] [PATCH] smc911x: make smc911x_initialize return correct value (Was: Re: [PATCH 1/5] smc911x: return -1 when initialization fails) Mike Rapoport
2009-11-13 3:44 ` Mike Frysinger
2009-11-11 8:03 ` [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs Mike Rapoport
2009-11-11 15:18 ` Mike Frysinger
2009-11-11 21:56 ` Mike Rapoport
2009-11-11 22:11 ` Mike Frysinger
2009-11-11 22:24 ` Mike Rapoport
2009-11-11 22:36 ` Mike Frysinger
2009-11-11 22:45 ` Ben Warren
2009-11-11 22:50 ` Mike Frysinger
2009-11-12 1:58 ` Ben Warren
2009-11-13 3:23 ` [U-Boot] [PATCH] smc911x_eeprom: fix building after smc911x overhaul Mike Frysinger
2009-11-13 3:26 ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-11-12 9:13 ` [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs Mike Rapoport
2009-11-13 3:21 ` Mike Frysinger
2009-11-11 8:03 ` [U-Boot] [PATCH 3/5] smc911x: silence MAC mismatch warning Mike Rapoport
2009-11-11 15:22 ` Mike Frysinger
2009-11-11 16:07 ` Mike Rapoport [this message]
2009-11-11 8:03 ` [U-Boot] [PATCH 4/5] smc911x: update SMC911X related configuration description Mike Rapoport
2009-12-07 21:06 ` Wolfgang Denk
2009-12-07 21:10 ` Ben Warren
2009-11-11 8:03 ` [U-Boot] [PATCH 5/5] smc911x: allow mac address to be kept after smc911x_halt Mike Rapoport
2009-11-11 15:23 ` Mike Frysinger
2009-11-11 16:05 ` Mike Rapoport
2009-11-11 16:32 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFAE138.9050504@compulab.co.il \
--to=mike@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.