From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs
Date: Wed, 11 Nov 2009 14:45:10 -0800 [thread overview]
Message-ID: <4AFB3E76.9090906@gmail.com> (raw)
In-Reply-To: <200911111736.25290.vapier@gentoo.org>
Hi Mike,
Mike Frysinger wrote:
> On Wednesday 11 November 2009 17:24:27 Mike Rapoport wrote:
>
>> On Thu, Nov 12, 2009 at 12:11 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>>
>>> On Wednesday 11 November 2009 16:56:57 Mike Rapoport wrote:
>>>
>>>> It seems that eeprom code is broken since commit
>>>> 736fead8fdbf8a8407048bebc373cd551d01ec98: "Convert SMC911X Ethernet
>>>> driver to CONFIG_NET_MULTI API".
>>>>
>>> broken how ? i recall it working ...
>>>
>> It gives pretty long list of compile errors. The smc911x.h header has
>> now 'struct eth_device *dev' parameter in all the functions.
>>
>
> yeah, i see that now. it wasnt noticed earlier as the config name changed but
> the eeprom code wasnt updated. i can take a look if you like since i wrote
> this sucker in the first place.
> -mike
>
>
You fixed the SMC91111 eeprom code by defining a 'struct eth_dev', but I
guess not the SMC9111x. I'm responsible for making this mess, so if you
don't have time I can take care of it (without being able to test, of
course :)
We can probably still fit such a bug fix in this release if we act quickly.
regards,
Ben
next prev parent reply other threads:[~2009-11-11 22:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 8:02 [U-Boot] [PATCH 0/5] smc911x driver fixes and additions Mike Rapoport
2009-11-11 8:03 ` [U-Boot] [PATCH 1/5] smc911x: return -1 when initialization fails Mike Rapoport
2009-11-11 15:16 ` Mike Frysinger
2009-11-12 13:35 ` [U-Boot] [PATCH] smc911x: make smc911x_initialize return correct value (Was: Re: [PATCH 1/5] smc911x: return -1 when initialization fails) Mike Rapoport
2009-11-13 3:44 ` Mike Frysinger
2009-11-11 8:03 ` [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs Mike Rapoport
2009-11-11 15:18 ` Mike Frysinger
2009-11-11 21:56 ` Mike Rapoport
2009-11-11 22:11 ` Mike Frysinger
2009-11-11 22:24 ` Mike Rapoport
2009-11-11 22:36 ` Mike Frysinger
2009-11-11 22:45 ` Ben Warren [this message]
2009-11-11 22:50 ` Mike Frysinger
2009-11-12 1:58 ` Ben Warren
2009-11-13 3:23 ` [U-Boot] [PATCH] smc911x_eeprom: fix building after smc911x overhaul Mike Frysinger
2009-11-13 3:26 ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-11-12 9:13 ` [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs Mike Rapoport
2009-11-13 3:21 ` Mike Frysinger
2009-11-11 8:03 ` [U-Boot] [PATCH 3/5] smc911x: silence MAC mismatch warning Mike Rapoport
2009-11-11 15:22 ` Mike Frysinger
2009-11-11 16:07 ` Mike Rapoport
2009-11-11 8:03 ` [U-Boot] [PATCH 4/5] smc911x: update SMC911X related configuration description Mike Rapoport
2009-12-07 21:06 ` Wolfgang Denk
2009-12-07 21:10 ` Ben Warren
2009-11-11 8:03 ` [U-Boot] [PATCH 5/5] smc911x: allow mac address to be kept after smc911x_halt Mike Rapoport
2009-11-11 15:23 ` Mike Frysinger
2009-11-11 16:05 ` Mike Rapoport
2009-11-11 16:32 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFB3E76.9090906@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.