* [Ocfs2-devel] [PATCH] ocfs2: Should error return be negative?
@ 2009-11-11 21:45 ` Roel Kluin
0 siblings, 0 replies; 2+ messages in thread
From: Roel Kluin @ 2009-11-11 21:45 UTC (permalink / raw)
To: Andrew Morton, LKML, mfasheh, joel.becker, ocfs2-devel
Return a negative error value instead of a positive
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
fs/ocfs2/dlm/dlmrecovery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The return of a positive error is unusual for oracle:
[roel at zoinx linux-git]$ git grep -n -E "return E[[:upper:]]*;" -- fs/ocfs2/ | wc -l
1
[roel at zoinx linux-git]$ git grep -n -E "return -E[[:upper:]]*;" -- fs/ocfs2/ | wc -l
251
is this maybe required?
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index d9fa3d2..0a8a6a4 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -2639,7 +2639,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
dlm->name, br->node_idx, br->dead_node,
dlm->reco.dead_node, dlm->reco.new_master);
spin_unlock(&dlm->spinlock);
- return EAGAIN;
+ return -EAGAIN;
}
spin_unlock(&dlm->spinlock);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ocfs2: Should error return be negative?
@ 2009-11-11 21:45 ` Roel Kluin
0 siblings, 0 replies; 2+ messages in thread
From: Roel Kluin @ 2009-11-11 21:45 UTC (permalink / raw)
To: Andrew Morton, LKML, mfasheh, joel.becker, ocfs2-devel
Return a negative error value instead of a positive
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
fs/ocfs2/dlm/dlmrecovery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The return of a positive error is unusual for oracle:
[roel@zoinx linux-git]$ git grep -n -E "return E[[:upper:]]*;" -- fs/ocfs2/ | wc -l
1
[roel@zoinx linux-git]$ git grep -n -E "return -E[[:upper:]]*;" -- fs/ocfs2/ | wc -l
251
is this maybe required?
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index d9fa3d2..0a8a6a4 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -2639,7 +2639,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
dlm->name, br->node_idx, br->dead_node,
dlm->reco.dead_node, dlm->reco.new_master);
spin_unlock(&dlm->spinlock);
- return EAGAIN;
+ return -EAGAIN;
}
spin_unlock(&dlm->spinlock);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-11 21:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-11 21:45 [Ocfs2-devel] [PATCH] ocfs2: Should error return be negative? Roel Kluin
2009-11-11 21:45 ` Roel Kluin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.