From: mike@mwester.net (Mike Westerhof)
To: linux-arm-kernel@lists.infradead.org
Subject: IXP4xx: unneeded #include platform-specific include files?
Date: Sun, 15 Nov 2009 12:41:32 -0600 [thread overview]
Message-ID: <4B004B5C.7000306@mwester.net> (raw)
In-Reply-To: <m3fx8fso72.fsf@intrepid.localdomain>
Krzysztof Halasa wrote:
> I wonder about one more thing: why are the platform-specific include
> files included by the non-platform code?
>
> mach-ixp4xx/include/mach/hardware.h:
>
> /* Platform specific details */
> #include "ixdp425.h"
> #include "avila.h"
> #include "coyote.h"
> #include "prpmc1100.h"
> #include "nslu2.h"
> #include "nas100d.h"
> #include "dsmg600.h"
> #include "fsg.h"
>
> I'm going to move them to the platform code, either incorporate them
> into platform .c files or #include "specific-platform.h" from there.
>
> Objections?
None at all (for nslu2 and dsmg600 platforms).
-Mike (mwester)
prev parent reply other threads:[~2009-11-15 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 17:16 IXP4xx: unneeded #include platform-specific include files? Krzysztof Halasa
2009-11-15 18:27 ` Mikael Pettersson
2009-11-15 20:18 ` Imre Kaloz
2009-11-15 21:14 ` Krzysztof Halasa
2009-11-17 21:37 ` Imre Kaloz
2009-11-17 21:53 ` Krzysztof Halasa
2009-11-17 22:11 ` Imre Kaloz
2009-11-17 22:22 ` Krzysztof Halasa
2009-11-17 22:34 ` Imre Kaloz
2009-11-17 22:47 ` Krzysztof Halasa
2009-11-17 23:05 ` Imre Kaloz
2009-11-18 0:10 ` Krzysztof Halasa
2009-11-15 18:41 ` Mike Westerhof [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B004B5C.7000306@mwester.net \
--to=mike@mwester.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.