From: kaloz@openwrt.org (Imre Kaloz)
To: linux-arm-kernel@lists.infradead.org
Subject: IXP4xx: unneeded #include platform-specific include files?
Date: Sun, 15 Nov 2009 21:18:45 +0100 [thread overview]
Message-ID: <op.u3gddjdi2s3iss@ecaz> (raw)
In-Reply-To: <19200.18453.644399.845601@pilspetsen.it.uu.se>
On Sun, 15 Nov 2009 19:27:33 +0100, Mikael Pettersson <mikpe@it.uu.se> wrote:
> Krzysztof Halasa writes:
> > I'm going to move them to the platform code, either incorporate them
> > into platform .c files or #include "specific-platform.h" from there.
> >
> > Objections?
>
> None. Having worked on the Synology DS101 support for mach-ixp4xx
> I'm 99,99% certain that platform details can and should be private.
>
Or people can simply stop the #define brain damage and use the GPIO defines.
(hint: IRQ_IXP4XX_GPIO* for PCI stuff, and the gpio number in i2c_gpio_platform_data)
Imre
next prev parent reply other threads:[~2009-11-15 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 17:16 IXP4xx: unneeded #include platform-specific include files? Krzysztof Halasa
2009-11-15 18:27 ` Mikael Pettersson
2009-11-15 20:18 ` Imre Kaloz [this message]
2009-11-15 21:14 ` Krzysztof Halasa
2009-11-17 21:37 ` Imre Kaloz
2009-11-17 21:53 ` Krzysztof Halasa
2009-11-17 22:11 ` Imre Kaloz
2009-11-17 22:22 ` Krzysztof Halasa
2009-11-17 22:34 ` Imre Kaloz
2009-11-17 22:47 ` Krzysztof Halasa
2009-11-17 23:05 ` Imre Kaloz
2009-11-18 0:10 ` Krzysztof Halasa
2009-11-15 18:41 ` Mike Westerhof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.u3gddjdi2s3iss@ecaz \
--to=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.