All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: Simon Horman <horms@verge.net.au>
Cc: Yuri Bushmelev <jay4mail@gmail.com>,
	Andrea Adami <andrea.adami@gmail.com>,
	kexec@lists.infradead.org
Subject: Re: [PATCH] kexec.c: workaround getline and fscanf to make it	*libc agnostic. Tested against klibc and dietlibc.
Date: Sun, 22 Nov 2009 10:24:30 +0100	[thread overview]
Message-ID: <4B09034E.40309@bwalle.de> (raw)
In-Reply-To: <20091122050350.GF2728@verge.net.au>

Simon Horman schrieb:
>
>> +	char *line = malloc(sizeof_line); /* according to strdup() later */
>
> 	Could line be char line[1024] ?

Better would be a constant. However, 1024 is too less since the maximum
command line size can be 2048 currently on x86
(arch/x86/include/asm/setup.h, #define COMMAND_LINE_SIZE 2048).



Regards,
Bernhard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2009-11-22  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-21 23:12 [PATCH] kexec.c: workaround getline and fscanf to make it *libc agnostic. Tested against klibc and dietlibc Andrea Adami
2009-11-22  5:03 ` Simon Horman
2009-11-22  9:24   ` Bernhard Walle [this message]
2009-11-25 23:17     ` Simon Horman
2009-11-25 23:37       ` Bernhard Walle
2009-11-26  0:14         ` Simon Horman
2009-11-26 10:34           ` Yuri Bushmelev
2009-11-26 19:28             ` Bernhard Walle
2009-11-26 21:42               ` Simon Horman
2009-11-27  7:05                 ` Bernhard Walle
2009-11-27  9:26                 ` Yuri Bushmelev
2009-11-27 10:48                   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B09034E.40309@bwalle.de \
    --to=bernhard@bwalle.de \
    --cc=andrea.adami@gmail.com \
    --cc=horms@verge.net.au \
    --cc=jay4mail@gmail.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.