From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] grub_video_fbrender_target
Date: Sun, 22 Nov 2009 14:01:00 +0100 [thread overview]
Message-ID: <4B09360C.7090809@gmail.com> (raw)
In-Reply-To: <20091122124853.GA10275@thorin>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
Robert Millan wrote:
> According to its description, struct grub_video_fbrender_target is a
> driver-specific structure. video_fb.c is generic code and shouldn't be
> using this struct to define its function calls, as this makes it impossible
> to use any of them from outside a driver.
>
>
grub_video_render_target is driver-specific but
grub_video_fbrender_target isn't. Host driver can either put
#define grub_video_render_target grub_video_fbrender_target
In which case driver effectively adopts fbrender_target as its
render_target or add encapsulators for video_fb functions. I think this
patch does more harm than good since if grub_video_render_target isn't
grub_video_fbrender_target then compiler won't complain.
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
next prev parent reply other threads:[~2009-11-22 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 12:48 [PATCH] grub_video_fbrender_target Robert Millan
2009-11-22 13:01 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2009-11-23 9:27 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B09360C.7090809@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.