[Xenomai-core] [PATCH] can: Free I/O region when unloading the xeno_can_isa.ko driver

[Xenomai-core] [PATCH] can: Free I/O region when unloading the xeno_can_isa.ko driver

[Sebastian Smolorz]

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

can: Free I/O region when unloading the xeno_can_isa.ko driver

Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>


[-- Attachment #2: rtcan_isa.diff --]
[-- Type: text/x-patch, Size: 779 bytes --]

diff --git a/ksrc/drivers/can/sja1000/rtcan_isa.c b/ksrc/drivers/can/sja1000/rtcan_isa.c
index 6debb16..ec32393 100644
--- a/ksrc/drivers/can/sja1000/rtcan_isa.c
+++ b/ksrc/drivers/can/sja1000/rtcan_isa.c
@@ -1,8 +1,8 @@
 /*
  * Copyright (C) 2006 Wolfgang Grandegger <wg@domain.hid>
  *
- * Copyright (C) 2005, 2006 Sebastian Smolorz
- *                          <Sebastian.Smolorz@domain.hid>
+ * Copyright (C) 2005, 2006, 2009 Sebastian Smolorz
+ *                               <smolorz@domain.hid>
  *
  *
  * This program is free software; you can redistribute it and/or modify it
@@ -189,6 +189,7 @@ static void rtcan_isa_exit(void)
 		if (!dev)
 			continue;
 		rtcan_sja1000_unregister(dev);
+		release_region(io[i], RTCAN_ISA_PORT_SIZE);
 		rtcan_dev_free(dev);
 	}
 }

Re: [Xenomai-core] [PATCH] can: Free I/O region when unloading the xeno_can_isa.ko driver

[Wolfgang Grandegger]

Sebastian Smolorz wrote:
> can: Free I/O region when unloading the xeno_can_isa.ko driver
> 
> Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>
Signed-off-by: Wolfgang Grandegger <wg@domain.hid>

Philippe, should I apply the patch?

Thanks,

Wolfgang.

Re: [Xenomai-core] [PATCH] can: Free I/O region when unloading the xeno_can_isa.ko driver

[Jan Kiszka]

Wolfgang Grandegger wrote:
> Sebastian Smolorz wrote:
>> can: Free I/O region when unloading the xeno_can_isa.ko driver
>>
>> Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>
> Signed-off-by: Wolfgang Grandegger <wg@domain.hid>
> 
> Philippe, should I apply the patch?

Do you have write access to the head git? Even if, this is not how that
tree is operated today. Either send pull request from a personal tree or
wait for Philippe to pick it up directly.

But I can also pick up Sebastian's patch and push it through my tree
(along with the other RTDM-related commit I've queued).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

Re: [Xenomai-core] [PATCH] can: Free I/O region when unloading the xeno_can_isa.ko driver

[Wolfgang Grandegger]

Jan Kiszka wrote:
> Wolfgang Grandegger wrote:
>> Sebastian Smolorz wrote:
>>> can: Free I/O region when unloading the xeno_can_isa.ko driver
>>>
>>> Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>
>> Signed-off-by: Wolfgang Grandegger <wg@domain.hid>
>>
>> Philippe, should I apply the patch?
> 
> Do you have write access to the head git? Even if, this is not how that
> tree is operated today. Either send pull request from a personal tree or
> wait for Philippe to pick it up directly.

Well, you are right. I actually never tried.

> But I can also pick up Sebastian's patch and push it through my tree
> (along with the other RTDM-related commit I've queued).

You are welcome.

Thanks,

Wolfgang.

Re: [Xenomai-core] [PATCH] can: Free I/O region when unloading the xeno_can_isa.ko driver

[Philippe Gerum]

On Mon, 2009-11-23 at 18:37 +0100, Wolfgang Grandegger wrote:
> Sebastian Smolorz wrote:
> > can: Free I/O region when unloading the xeno_can_isa.ko driver
> > 
> > Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>
> Signed-off-by: Wolfgang Grandegger <wg@domain.hid>
> 
> Philippe, should I apply the patch?

Just picked it from Jan's queue. Thanks.

> 
> Thanks,
> 
> Wolfgang.


-- 
Philippe.