* pkgconfig bbclass: also sed out bogus includes
@ 2009-11-25 12:46 Sebastian Spaeth
2009-11-25 13:21 ` Koen Kooi
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Spaeth @ 2009-11-25 12:46 UTC (permalink / raw)
To: openembedded-devel
> author Koen Kooi <koen@openembedded.org>
> commit 2c8134baa56ad047f5c37069379c0e560dd6477e
>
> RP says: In theory the recipes themselves should be patched to stop
> this nonesense getting in there in the first place but that is
> appropriate for pkgconfig.bbclass
Nice one. Should we add a warning when we find such a bogus include so
recipes can be fixed up over time?
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: pkgconfig bbclass: also sed out bogus includes
2009-11-25 12:46 pkgconfig bbclass: also sed out bogus includes Sebastian Spaeth
@ 2009-11-25 13:21 ` Koen Kooi
2009-11-25 14:27 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Koen Kooi @ 2009-11-25 13:21 UTC (permalink / raw)
To: openembedded-devel
On 25-11-09 13:46, Sebastian Spaeth wrote:
>> author Koen Kooi<koen@openembedded.org>
>> commit 2c8134baa56ad047f5c37069379c0e560dd6477e
>>
>> RP says: In theory the recipes themselves should be patched to stop
>> this nonesense getting in there in the first place but that is
>> appropriate for pkgconfig.bbclass
>
> Nice one. Should we add a warning when we find such a bogus include so
> recipes can be fixed up over time?
Before this commit insane.bbclass aborted the build during
do_qa_staging, so I don't think there are a lot of such recipes around :)
Feel free to add such a warning to this class.
I ran into this issue with eet.pc when trying to build a newer e-wm.
regards,
Koen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: pkgconfig bbclass: also sed out bogus includes
2009-11-25 13:21 ` Koen Kooi
@ 2009-11-25 14:27 ` Richard Purdie
0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2009-11-25 14:27 UTC (permalink / raw)
To: openembedded-devel
On Wed, 2009-11-25 at 14:21 +0100, Koen Kooi wrote:
> On 25-11-09 13:46, Sebastian Spaeth wrote:
> >> author Koen Kooi<koen@openembedded.org>
> >> commit 2c8134baa56ad047f5c37069379c0e560dd6477e
> >>
> >> RP says: In theory the recipes themselves should be patched to stop
> >> this nonesense getting in there in the first place but that is
> >> appropriate for pkgconfig.bbclass
> >
> > Nice one. Should we add a warning when we find such a bogus include so
> > recipes can be fixed up over time?
>
> Before this commit insane.bbclass aborted the build during
> do_qa_staging, so I don't think there are a lot of such recipes around :)
>
> Feel free to add such a warning to this class.
>
> I ran into this issue with eet.pc when trying to build a newer e-wm.
Now is probably a good time to discuss some ideas. In Poky I split
pkgconfig.bbclass into two, with pkgconfig.bbclass just adding
pkgconfig-native into DEPENDS.
How about we just require pkgconfig-native as part of the default
DEPENDS and start removing pkgconfig.bbclass everywhere we can?
Ifs its needed anywhere there is a bug in the application's use of .pc
files.
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-25 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-25 12:46 pkgconfig bbclass: also sed out bogus includes Sebastian Spaeth
2009-11-25 13:21 ` Koen Kooi
2009-11-25 14:27 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.