* Conexant CX20549 (Venice) PCM volume to loud @ 2009-11-25 16:41 Cristian KLEIN 2009-11-25 23:37 ` Daniel Chen 0 siblings, 1 reply; 4+ messages in thread From: Cristian KLEIN @ 2009-11-25 16:41 UTC (permalink / raw) To: alsa-devel Hello, Could anybody please have a look at this bug: https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4792 Thanks in advance, Cristi. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Conexant CX20549 (Venice) PCM volume to loud 2009-11-25 16:41 Conexant CX20549 (Venice) PCM volume to loud Cristian KLEIN @ 2009-11-25 23:37 ` Daniel Chen 2009-11-26 9:13 ` Takashi Iwai 0 siblings, 1 reply; 4+ messages in thread From: Daniel Chen @ 2009-11-25 23:37 UTC (permalink / raw) To: Cristian KLEIN, Takashi Iwai; +Cc: alsa-devel [-- Attachment #1: Type: text/plain, Size: 288 bytes --] Hi, On Wed, Nov 25, 2009 at 11:41 AM, Cristian KLEIN <cristiklein@gmail.com> wrote: > Could anybody please have a look at this bug: > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4792 I've spun the attached patch against current sound-2.6 HEAD. Thanks for chasing this! -Dan [-- Attachment #2: 0001-ALSA-hda-Fix-max-PCM-level-to-0-dB-for-Fujitsu-Sieme.patch --] [-- Type: text/x-diff, Size: 1418 bytes --] From 767036ef9f1c05fe2fc0e9fa226b4f33076e9703 Mon Sep 17 00:00:00 2001 From: Daniel T Chen <crimsun@ubuntu.com> Date: Wed, 25 Nov 2009 18:27:20 -0500 Subject: [PATCH] ALSA: hda: Fix max PCM level to 0 dB for Fujitsu-Siemens laptops using CX20549 (Venice) BugLink: https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4792 Cristian reported that these models have really bad sound above 6 dB and proposed the original patch. I've updated the comment to reflect this change. Signed-off-by: Daniel T Chen <crimsun@ubuntu.com> Reported-by: Cristian Klein --- sound/pci/hda/patch_conexant.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 36dd5a6..60810ba 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -1171,9 +1171,10 @@ static int patch_cxt5045(struct hda_codec *codec) switch (codec->subsystem_id >> 16) { case 0x103c: - /* HP laptop has a really bad sound over 0dB on NID 0x17. - * Fix max PCM level to 0 dB - * (originall it has 0x2b steps with 0dB offset 0x14) + case 0x1734: + /* HP & Fujitsu-Siemens laptops have really bad sound over 0dB + * on NID 0x17. Fix max PCM level to 0 dB + * (originally it has 0x2b steps with 0dB offset 0x14) */ snd_hda_override_amp_caps(codec, 0x17, HDA_INPUT, (0x14 << AC_AMPCAP_OFFSET_SHIFT) | -- 1.6.3.3 [-- Attachment #3: Type: text/plain, Size: 160 bytes --] _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Conexant CX20549 (Venice) PCM volume to loud 2009-11-25 23:37 ` Daniel Chen @ 2009-11-26 9:13 ` Takashi Iwai 2009-11-26 15:00 ` Cristian KLEIN 0 siblings, 1 reply; 4+ messages in thread From: Takashi Iwai @ 2009-11-26 9:13 UTC (permalink / raw) To: Daniel Chen; +Cc: alsa-devel, Cristian KLEIN At Wed, 25 Nov 2009 18:37:36 -0500, Daniel Chen wrote: > > Hi, > > On Wed, Nov 25, 2009 at 11:41 AM, Cristian KLEIN <cristiklein@gmail.com> wrote: > > Could anybody please have a look at this bug: > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4792 > > I've spun the attached patch against current sound-2.6 HEAD. Thanks > for chasing this! Thanks, applied now. Takashi > > -Dan > [2 0001-ALSA-hda-Fix-max-PCM-level-to-0-dB-for-Fujitsu-Sieme.patch <text/x-diff; US-ASCII (base64)>] > From 767036ef9f1c05fe2fc0e9fa226b4f33076e9703 Mon Sep 17 00:00:00 2001 > From: Daniel T Chen <crimsun@ubuntu.com> > Date: Wed, 25 Nov 2009 18:27:20 -0500 > Subject: [PATCH] ALSA: hda: Fix max PCM level to 0 dB for Fujitsu-Siemens laptops using CX20549 (Venice) > > BugLink: https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4792 > > Cristian reported that these models have really bad sound above 6 dB > and proposed the original patch. I've updated the comment to reflect > this change. > > Signed-off-by: Daniel T Chen <crimsun@ubuntu.com> > Reported-by: Cristian Klein > --- > sound/pci/hda/patch_conexant.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > index 36dd5a6..60810ba 100644 > --- a/sound/pci/hda/patch_conexant.c > +++ b/sound/pci/hda/patch_conexant.c > @@ -1171,9 +1171,10 @@ static int patch_cxt5045(struct hda_codec *codec) > > switch (codec->subsystem_id >> 16) { > case 0x103c: > - /* HP laptop has a really bad sound over 0dB on NID 0x17. > - * Fix max PCM level to 0 dB > - * (originall it has 0x2b steps with 0dB offset 0x14) > + case 0x1734: > + /* HP & Fujitsu-Siemens laptops have really bad sound over 0dB > + * on NID 0x17. Fix max PCM level to 0 dB > + * (originally it has 0x2b steps with 0dB offset 0x14) > */ > snd_hda_override_amp_caps(codec, 0x17, HDA_INPUT, > (0x14 << AC_AMPCAP_OFFSET_SHIFT) | > -- > 1.6.3.3 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Conexant CX20549 (Venice) PCM volume to loud 2009-11-26 9:13 ` Takashi Iwai @ 2009-11-26 15:00 ` Cristian KLEIN 0 siblings, 0 replies; 4+ messages in thread From: Cristian KLEIN @ 2009-11-26 15:00 UTC (permalink / raw) To: Takashi Iwai; +Cc: Daniel Chen, alsa-devel On 26/11/2009 10:13, Takashi Iwai wrote: > At Wed, 25 Nov 2009 18:37:36 -0500, > Daniel Chen wrote: >> >> Hi, >> >> On Wed, Nov 25, 2009 at 11:41 AM, Cristian KLEIN<cristiklein@gmail.com> wrote: >>> Could anybody please have a look at this bug: >>> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4792 >> >> I've spun the attached patch against current sound-2.6 HEAD. Thanks >> for chasing this! > > Thanks, applied now. Great! Can't wait for linux-backports-modules-alsa to catch his. Sorry for not submitting a nice patch from start. Could anybody close the original bug report? ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-26 15:00 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-11-25 16:41 Conexant CX20549 (Venice) PCM volume to loud Cristian KLEIN 2009-11-25 23:37 ` Daniel Chen 2009-11-26 9:13 ` Takashi Iwai 2009-11-26 15:00 ` Cristian KLEIN
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.