From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 1/2] tabled: drop dependency on libevent from libcldc
Date: Sat, 28 Nov 2009 04:08:32 -0500 [thread overview]
Message-ID: <4B10E890.3010408@garzik.org> (raw)
In-Reply-To: <20091128000732.42003d5a@redhat.com>
On 11/28/2009 02:07 AM, Pete Zaitcev wrote:
> On Sat, 28 Nov 2009 00:09:09 -0500
> Jeff Garzik<jeff@garzik.org> wrote:
>> On 11/27/2009 10:52 PM, Pete Zaitcev wrote:
>
>>> The patched tabled can build and work with the "old" libcldc too.
>>
>> Part of the reason for that is the continued presence of @EVENT_LIBS@ in
>> configure.ac and select Makefile.am files.
>>
>> Have you fixed that up in a follow-up patch, or is that missing?
>
> tabled continues to use libevent, only CLD stops it.
True; only chunkd needs the modification, then.
>> It seems to me that your patch #2 should be patch #1, followed by
>> patches to chunkd and tabled removing the libevent dependency.
>
> If you apply #1, nothing bad happens, tabled continues to build
> like before, no matter what CLD is under it. This is why it's #1.
> If you decided that #2 was unacceptable and tabled would not be
> compatible, we'd have a broken tabled, right?
Fair enough. I will apply the tabled patch immediately, and await
comments/revisions on the CLD patch (see other email).
Jeff
next prev parent reply other threads:[~2009-11-28 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 3:52 [Patch 1/2] tabled: drop dependency on libevent from libcldc Pete Zaitcev
2009-11-28 5:09 ` Jeff Garzik
2009-11-28 7:07 ` Pete Zaitcev
2009-11-28 9:08 ` Jeff Garzik [this message]
2009-11-28 9:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B10E890.3010408@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.