[PATCH 07/14]: libxenlight, destroy device-model only for hvm domains

[PATCH 07/14]: libxenlight, destroy device-model only for hvm domains

[Andres Lagar-Cavilla]

[-- Attachment #1: Type: text/plain, Size: 107 bytes --]

Destroy device-model only for hvm domains.

Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.com>


[-- Attachment #2: 07_destroy_dm_only_hvm.patch --]
[-- Type: text/x-patch, Size: 1896 bytes --]

# HG changeset patch
# User Andres Lagar-Cavilla <andres@lagarcavilla.com>
# Date 1259253630 18000
# Node ID 05e2dad9b117e80c8daf55a30cb7eeda3fda4764
# Parent  a19e1cef7b72a90b3cc9c8c38dadf06aaf413155
Destroy device-model only for hvm domains.

Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.com>

diff -r a19e1cef7b72 -r 05e2dad9b117 libxl.c
--- a/libxl.c
+++ b/libxl.c
@@ -443,8 +443,9 @@ int libxl_domain_destroy(struct libxl_ct
 {
     char *dom_path, vm_path[41];
     xen_uuid_t *uuid;
-    int rc;
+    int rc, hvm;
 
+    hvm = is_hvm(ctx, domid);
     dom_path = libxl_xs_get_dompath(ctx, domid);
     if (!dom_path)
         return -1;
@@ -455,16 +456,20 @@ int libxl_domain_destroy(struct libxl_ct
     }
     if (libxl_device_pci_shutdown(ctx, domid) < 0)
         XL_LOG(ctx, XL_LOG_ERROR, "pci shutdown failed for domid %d", domid);
-    xs_write(ctx->xsh, XBT_NULL,
-             libxl_sprintf(ctx, "/local/domain/0/device-model/%d/command", domid),
-             "shutdown", strlen("shutdown"));
+    if (hvm) {
+        xs_write(ctx->xsh, XBT_NULL,
+                 libxl_sprintf(ctx, "/local/domain/0/device-model/%d/command", domid),
+                 "shutdown", strlen("shutdown"));
+    }
     rc = xc_domain_pause(ctx->xch, domid);
     if (rc < 0) {
         XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, rc, "xc_domain_pause failed for %d", domid);
         return -1;
     }
-    if (libxl_destroy_device_model(ctx, domid) < 0)
-        XL_LOG(ctx, XL_LOG_ERROR, "libxl_destroy_device_model failed for %d", domid);
+    if (hvm) {
+        if (libxl_destroy_device_model(ctx, domid) < 0)
+            XL_LOG(ctx, XL_LOG_ERROR, "libxl_destroy_device_model failed for %d", domid);
+    }
     if (libxl_devices_destroy(ctx, domid, force) < 0)
         XL_LOG(ctx, XL_LOG_ERROR, "libxl_destroy_devices failed for %d", domid);
     if (!xs_rm(ctx->xsh, XBT_NULL, dom_path))

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 07/14]: libxenlight, destroy device-model only for hvm domains

[Vincent Hanquez]

On Mon, Nov 30, 2009 at 07:13:49PM +0000, Andres Lagar-Cavilla wrote:
> Destroy device-model only for hvm domains.
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.com>
> 

> # HG changeset patch
> # User Andres Lagar-Cavilla <andres@lagarcavilla.com>
> # Date 1259253630 18000
> # Node ID 05e2dad9b117e80c8daf55a30cb7eeda3fda4764
> # Parent  a19e1cef7b72a90b3cc9c8c38dadf06aaf413155
> Destroy device-model only for hvm domains.

no, we need to destroy the device-model if it is present,
and beeing PV doesn't means you don't have a device-model.

-- 
Vincent