From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Yu, Ke" <ke.yu@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
"'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup
Date: Mon, 30 Nov 2009 12:05:39 -0800 [thread overview]
Message-ID: <4B142593.7020801@goop.org> (raw)
In-Reply-To: <4D05DB80B95B23498C72C700BD6C2E0B36A73D50@pdsmsx502.ccr.corp.intel.com>
On 11/26/09 18:23, Yu, Ke wrote:
> I tried making xen code modular before, the issue here is the two-way dependency among acpi processor driver (driver/acpi/processor_core.c) and xen driver (driver/xen/acpi_processor.c). firstly, acpi processor driver depend on xen driver routine processor_cntl_xen_notify(). Secondly, if xen driver depend on some routine of acpi processor driver (e.g. acpi_set_processor_driver as you mentioned), then there is two way dependency between these two modules, which cannot pass compilation. so what I have done in last patch is moving related code from xen part to acpi processor driver part, to eliminate the xen->acpi processor dependency.
Well, you can either make it a looser coupling by making the acpi->xen
call via a function pointer, or by using Kconfig to make sure that the
Xen code and the ACPI code are always compiled in a compatible way (ie,
both builtin or both modules).
J
prev parent reply other threads:[~2009-11-30 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 11:55 [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup Yu, Ke
2009-11-25 18:48 ` Jeremy Fitzhardinge
2009-11-26 8:29 ` Yu, Ke
2009-11-26 8:44 ` Jeremy Fitzhardinge
2009-11-27 2:23 ` Yu, Ke
2009-11-30 20:05 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B142593.7020801@goop.org \
--to=jeremy@goop.org \
--cc=ke.yu@intel.com \
--cc=len.brown@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.