Re: [PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start()

[Joonyoung Shim <jy0922.shim@samsung.com>]

Hi, Tobias.

On 12/2/2009 8:39 AM, Tobias Lorenz wrote:
> Hi,
> 
> what is the advantage in not setting SYSCONFIG1 into a known state?
> 

At patch 3/3, i am setting the SYSCONFIG1 register for RDS interrupt in
i2c probe function, so i need this patch. Do you have other idea?

> Bye,
> Toby
> 
> Am Mittwoch 18 November 2009 07:21:25 schrieb Joonyoung Shim:
>> We should use the or operation to set value to the SYSCONFIG1 register
>> on si470x_start().
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> ---
>>  drivers/media/radio/si470x/radio-si470x-common.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/radio/si470x/radio-si470x-common.c b/drivers/media/radio/si470x/radio-si470x-common.c
>> index f33315f..09f631a 100644
>> --- a/drivers/media/radio/si470x/radio-si470x-common.c
>> +++ b/drivers/media/radio/si470x/radio-si470x-common.c
>> @@ -357,7 +357,7 @@ int si470x_start(struct si470x_device *radio)
>>  		goto done;
>>  
>>  	/* sysconfig 1 */
>> -	radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
>> +	radio->registers[SYSCONFIG1] |= SYSCONFIG1_DE;
>>  	retval = si470x_set_register(radio, SYSCONFIG1);
>>  	if (retval < 0)
>>  		goto done;
>>
>