All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Tobias Lorenz <tobias.lorenz@gmx.net>
Cc: linux-media@vger.kernel.org, mchehab@infradead.org,
	kyungmin.park@samsung.com
Subject: Re: [PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start()
Date: Wed, 02 Dec 2009 09:32:09 +0900	[thread overview]
Message-ID: <4B15B589.2020805@samsung.com> (raw)
In-Reply-To: <200912020112.59668.tobias.lorenz@gmx.net>

On 12/2/2009 9:12 AM, Tobias Lorenz wrote:
> Hi,
> 
> ok, understood this problem.
> So, why not set this in si470x_fops_open directly after the si470x_start?
> It seems more appropriate to enable the RDS interrupt after starting the radio.
> 

OK, it makes sense. I will move it in si470x_fops_open.

> Bye the way, you pointed me to a bug. Instead of always setting de-emphasis in si470x_start:
> radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
> This should only be done, if requested by module parameter:
> radio->registers[SYSCONFIG1] = (de << 11) & SYSCONFIG1_DE; /* DE */
> 

Ah, That's right.

Thanks.

      reply	other threads:[~2009-12-02  0:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18  6:21 [PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start() Joonyoung Shim
2009-12-01 23:39 ` Tobias Lorenz
2009-12-01 23:54   ` Joonyoung Shim
2009-12-02  0:12     ` Tobias Lorenz
2009-12-02  0:32       ` Joonyoung Shim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B15B589.2020805@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=tobias.lorenz@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.